r64282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64281‎ | r64282 | r64283 >
Date:01:41, 28 March 2010
Author:simetrical
Status:ok
Tags:
Comment:
Backport r64281 "Remove a use of xml:lang that I missed in r62312"

Backported so that xml:lang isn't mysteriously permitted for one release
and then forbidden again. Original commit message:

If this is required for some reason for RDFa, it should be allowed only
when RDFa is enabled, like xmlns:.
Modified paths:
  • /branches/REL1_16/phase3/includes/Sanitizer.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/Sanitizer.php
——@@ -1253,7 +1253,7 @@
12541254 static function setupAttributeWhitelist() {
12551255 global $wgAllowRdfaAttributes, $wgHtml5, $wgAllowMicrodataAttributes;
12561256
1257 - $common = array( 'id', 'class', 'lang', 'dir', 'title', 'style', 'xml:lang' );
 1257+ $common = array( 'id', 'class', 'lang', 'dir', 'title', 'style' );
12581258
12591259 if ( $wgAllowRdfaAttributes ) {
12601260 #RDFa attributes as specified in section 9 of http://www.w3.org/TR/2008/REC-rdfa-syntax-20081014

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62312War on xml:lang...simetrical17:25, 11 February 2010
r64281Remove a use of xml:lang that I missed in r62312...simetrical01:37, 28 March 2010

Status & tagging log