r64255 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64254‎ | r64255 | r64256 >
Date:15:03, 27 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
new-installer: now works with MySQL
Modified paths:
  • /branches/new-installer/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/MysqlInstaller.php
@@ -385,7 +385,18 @@
386386 }
387387
388388 function createTables() {
389 -
 389+ global $IP;
 390+ $status = $this->getConnection();
 391+ if ( !$status->isOK() ) {
 392+ return $status;
 393+ }
 394+ $this->db->selectDB( $this->getVar( 'wgDBname' ) );
 395+ if ( !$this->db->sourceFile( "$IP/maintenance/tables.sql" )
 396+ || !$this->db->sourceFile( "$IP/maintenance/interwiki.sql" ) )
 397+ {
 398+ //@todo
 399+ }
 400+ return Status::newGood();
390401 }
391402
392403 function getTableOptions() {
Index: branches/new-installer/phase3/includes/installer/OracleInstaller.php
@@ -93,6 +93,8 @@
9494
9595 function setupDatabase() {}
9696
 97+ function createTables() {}
 98+
9799 function getLocalSettings() {
98100 $prefix = $this->getVar( 'wgDBprefix' );
99101 return
Index: branches/new-installer/phase3/includes/installer/PostgresInstaller.php
@@ -127,6 +127,9 @@
128128 function setupDatabase() {
129129 }
130130
 131+ function createTables() {
 132+ }
 133+
131134 function getLocalSettings() {
132135 $port = $this->getVar( 'wgDBport' );
133136 $schema = $this->getVar( 'wgDBmwschema' );

Status & tagging log