r64194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64193‎ | r64194 | r64195 >
Date:21:52, 25 March 2010
Author:neilk
Status:deferred
Tags:
Comment:
Fixed small bugs with author form
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js
@@ -1629,8 +1629,8 @@
16301630 $j( '#mwe-upwiz-source-thirdparty' ).click( function() { _this.showDeedThirdParty(); } );
16311631 $j( '#mwe-upwiz-source-thirdparty' ).click( function() { _this.showDeedChoice() } );
16321632
1633 - $j( '.mwe-upwiz-macro-edit-submit' ).each(
1634 - this.append( $j( '<input />' )
 1633+ $j( '.mwe-upwiz-macro-edit-submit' ).each( function() {
 1634+ $j( this ).append( $j( '<input />' )
16351635 .addClass( 'mwe-details-submit' )
16361636 .attr( { type: 'submit', value: gM( 'mwe-upwiz-macro-edit' ) } )
16371637 .click( function() {
@@ -1641,7 +1641,7 @@
16421642 _this.moveToTab('thanks');
16431643 } );
16441644 } ) );
1645 - );
 1645+ } );
16461646
16471647
16481648 // add one to start
@@ -2042,7 +2042,7 @@
20432043 // transition ?
20442044
20452045 var sourceInput = $j( '<input />').attr( { name: "source", value: "{{ownwork}}" } );
2046 - var authorInput = $j( '#mwe-upwiz-macro-deed-ownwork-form' ).find( 'input[name=author]' ).get(0);
 2046+ var authorInput = $j( '<input />').attr( { name: "author" } ); // value set below
20472047 var licenseInputDiv = $j( '<div></div>' );
20482048 var licenseInput = new mw.UploadWizardLicenseInput( licenseInputDiv );
20492049 licenseInput.setDefaultValues();

Status & tagging log