r64085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64084‎ | r64085 | r64086 >
Date:19:16, 23 March 2010
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
UsabilityInitiative: Add preference for CollapsibleNav. Stuck it in Appearance -> Advanced options for now; if this feature doesn't get enabled by default in April it'll probably e moved to a new Appearance -> Labs features section.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Vector.php
@@ -20,7 +20,7 @@
2121
2222 // Each module may be configured individually to be globally on/off or user preference based
2323 $wgVectorModules = array(
24 - 'collapsiblenav' => array( 'global' => true, 'user' => false ),
 24+ 'collapsiblenav' => array( 'global' => false, 'user' => true ),
2525 'collapsibletabs' => array( 'global' => true, 'user' => false ),
2626 'editwarning' => array( 'global' => false, 'user' => true ),
2727 'footercleanup' => array( 'global' => false, 'user' => false ),
@@ -49,6 +49,7 @@
5050 $wgExtensionMessagesFiles['Vector'] = dirname( __FILE__ ) . '/Vector.i18n.php';
5151 $wgExtensionMessagesFiles['VectorEditWarning'] = dirname( __FILE__ ) . '/Modules/EditWarning/EditWarning.i18n.php';
5252 $wgExtensionMessagesFiles['VectorSimpleSearch'] = dirname( __FILE__ ) . '/Modules/SimpleSearch/SimpleSearch.i18n.php';
 53+$wgExtensionMessagesFiles['VectorCollapsibleNav'] = dirname( __FILE__ ) . '/Modules/CollapsibleNav/CollapsibleNav.i18n.php';
5354
5455 // Register Hooks
5556 $wgHooks['UsabilityInitiativeLoadModules'][] = 'VectorHooks::addModules';
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -27,6 +27,17 @@
2828 );
2929 static $modules = array(
3030 'collapsiblenav' => array(
 31+ 'i18n' => 'VectorCollapsibleNav',
 32+ 'preferences' => array(
 33+ 'enable' => array(
 34+ 'key' => 'vector-collapsiblenav',
 35+ 'ui' => array(
 36+ 'type' => 'toggle',
 37+ 'label-message' => 'vector-collapsiblenav-preference',
 38+ 'section' => 'rendering/advancedrendering',
 39+ ),
 40+ ),
 41+ ),
3142 ),
3243 'collapsibletabs' => array(
3344 ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r64086wmf-deployment: MFT r64085catrope19:19, 23 March 2010
r64109Add forgotten file for r64085catrope10:12, 24 March 2010

Comments

#Comment by 😂 (talk | contribs)   01:29, 24 March 2010

Did you miss a svn add on that i18n file?

#Comment by Catrope (talk | contribs)   20:22, 24 March 2010

I did indeed. File added in r64109.

Status & tagging log