r64075 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64074‎ | r64075 | r64076 >
Date:15:16, 23 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
new-installer: fixed numerous XHTML compliance problems
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /branches/new-installer/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/new-installer/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/maintenance/language/messages.inc
@@ -3139,7 +3139,8 @@
31403140 'ajax-error-dismiss',
31413141 'ajax-remove-category-error',
31423142 ),
3143 - 'config' => array(
 3143+ 'config' => array(
 3144+ 'config-information',
31443145 'config-session-error',
31453146 'config-session-expired',
31463147 'config-no-session',
Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -427,7 +427,8 @@
428428 "<div class=\"config-info-left\">\n" .
429429 Xml::element( 'img',
430430 array(
431 - 'src' => '../skins/common/images/' . $icon
 431+ 'src' => '../skins/common/images/' . $icon,
 432+ 'alt' => wfMsg( 'config-information' ),
432433 )
433434 ) . "\n" .
434435 "</div>\n" .
@@ -450,12 +451,13 @@
451452 $text = wfMsgReal( $msg, $args, false, false, false );
452453 $html = $this->parse( $text, true );
453454 $id = $this->helpId++;
 455+ $alt = wfMsg( 'help' );
454456
455457 return
456458 "<div class=\"config-help-wrapper\">\n" .
457459 "<div class=\"config-show-help\" id=\"config-show-help-$id\">\n" .
458460 Xml::openElement( 'a', array( 'href' => "javascript:showHelp($id,true)" ) ) .
459 - "<img src=\"../skins/common/images/help-22.png\"/>&nbsp;&nbsp;" .
 461+ "<img src=\"../skins/common/images/help-22.png\" alt=\"$alt\" />&nbsp;&nbsp;" .
460462 wfMsgHtml( 'config-show-help' ) .
461463 "</a></div>\n" .
462464 "<div class=\"config-help-message\" id=\"config-help-message-$id\">\n" .
@@ -463,7 +465,7 @@
464466 "</div>\n" .
465467 "<div class=\"config-hide-help\" id=\"config-hide-help-$id\">\n" .
466468 Xml::openElement( 'a', array( 'href' => "javascript:showHelp($id,false)" ) ) .
467 - "<img src=\"../skins/common/images/help-22.png\"/>&nbsp;&nbsp;" .
 469+ "<img src=\"../skins/common/images/help-22.png\" alt=\"$alt\" />&nbsp;&nbsp;" .
468470 wfMsgHtml( 'config-hide-help' ) .
469471 "</a></div>\n</div>\n";
470472 }
@@ -500,10 +502,14 @@
501503 } else {
502504 $labelText = wfMsgHtml( $msg );
503505 }
 506+ $attributes = array( 'class' => 'config-label' );
 507+ if ( $forId ) {
 508+ $attributes['for'] = $forId;
 509+ }
504510 return
505511 "<div class=\"config-input\">\n" .
506512 Xml::tags( 'label',
507 - array( 'for' => $forId, 'class' => 'config-label' ),
 513+ $attributes,
508514 $labelText ) . "\n" .
509515 $contents .
510516 "</div>\n";
@@ -883,9 +889,9 @@
884890 $languages = Language::getLanguageNames();
885891 ksort( $languages );
886892 $dummies = array_flip( $wgDummyLanguageCodes );
887 - foreach ( $languages as $code => $name ) {
 893+ foreach ( $languages as $code => $lang ) {
888894 if ( isset( $dummies[$code] ) ) continue;
889 - $s .= "\n" . Xml::option( "$code - $name", $code, $code == $selectedCode );
 895+ $s .= "\n" . Xml::option( "$code - $lang", $code, $code == $selectedCode );
890896 }
891897 $s .= "\n</select>\n";
892898 return $this->parent->label( $label, $name, $s );
Index: branches/new-installer/phase3/includes/installer/WebInstallerOutput.php
@@ -99,7 +99,7 @@
100100
101101 <body class="<?php print $this->getDir(); ?>">
102102 <noscript>
103 -<style>
 103+<style type="text/css">
104104 .config-help-message { display: block; }
105105 .config-show-help { display: none; }
106106 </style>
Index: branches/new-installer/phase3/languages/messages/MessagesEn.php
@@ -4121,6 +4121,7 @@
41224122 'duplicate-defaultsort' => '\'\'\'Warning:\'\'\' Default sort key "$2" overrides earlier default sort key "$1".',
41234123
41244124 # Installer
 4125+'config-information' => 'Information',
41254126 'config-session-error' => 'Error starting session: $1',
41264127 'config-session-expired' => 'Your session data seems to have expired.
41274128 Sessions are configured for a lifetime of $1, you can increase this by setting session.gc_maxlifetime in php.ini.

Status & tagging log