r64064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64063‎ | r64064 | r64065 >
Date:08:58, 23 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
new-installer: fixed undefined variable warning
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -817,12 +817,13 @@
818818 $userLang = $r->getVal( 'UserLang' );
819819 $contLang = $r->getVal( 'ContLang' );
820820
 821+ $lifetime = intval( ini_get( 'session.gc_maxlifetime' ) );
 822+ if ( !$lifetime ) {
 823+ $lifetime = 1440; // PHP default
 824+ }
 825+
821826 if ( $r->wasPosted() ) {
822827 # Do session test
823 - $lifetime = intval( ini_get( 'session.gc_maxlifetime' ) );
824 - if ( !$lifetime ) {
825 - $lifetime = 1440; // PHP default
826 - }
827828 if ( $this->parent->getSession( 'test' ) === null ) {
828829 $requestTime = $r->getVal( 'LanguageRequestTime' );
829830 if ( !$requestTime ) {

Status & tagging log