r63864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63863‎ | r63864 | r63865 >
Date:16:46, 17 March 2010
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: Fix undefined variable in r63825, consistent casing
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.publish.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -79,13 +79,13 @@
8080 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 97 ),
8181 array( 'src' => 'js/plugins/jquery.wikiEditor.preview.js', 'version' => 11 ),
8282 array( 'src' => 'js/plugins/jquery.wikiEditor.templateEditor.js', 'version' => 66 ),
83 - array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 3 ),
 83+ array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 4 ),
8484 ),
8585 'combined' => array(
86 - array( 'src' => 'js/plugins.combined.js', 'version' => 350 ),
 86+ array( 'src' => 'js/plugins.combined.js', 'version' => 351 ),
8787 ),
8888 'minified' => array(
89 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 350 ),
 89+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 351 ),
9090 ),
9191 ),
9292 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.publish.js
@@ -65,20 +65,21 @@
6666 });
6767
6868 // Reformat the copyright warning stuff
69 - var copywarnHTML = $( '#editpage-copywarn' ).html();
 69+ var copyWarnHTML = $( '#editpage-copywarn' ).html();
7070
7171 // TODO: internationalize by splitting on other characters that end statements
72 - var copywarnStatements = copywarnHTML.split( '. ' );
73 - for ( var i = 0; i < copywarnStatements.length; i++ ) {
74 - if ( copywarnStatements[i] != '' ) {
75 - newcopywarnHTML += '<li>' + copywarnStatements[i] + '. </li>';
 72+ var copyWarnStatements = copyWarnHTML.split( '. ' );
 73+ var newCopyWarnHTML = '';
 74+ for ( var i = 0; i < copyWarnStatements.length; i++ ) {
 75+ if ( copyWarnStatements[i] != '' ) {
 76+ newCopyWarnHTML += '<li>' + copyWarnStatements[i] + '. </li>';
7677 }
7778 }
78 - newcopywarnHTML += '</ul>';
 79+ newCopyWarnHTML += '</ul>';
7980
8081 // No list if there's only one element
8182 $(this).find( '.wikiEditor-dialog-copywarn' ).html(
82 - copywarnStatements.length > 1 ? newcopywarnHTML : copywarnHTML );
 83+ copyWarnStatements.length > 1 ? newCopyWarnHTML : copyWarnHTML );
8384
8485 if ( $( '#wpMinoredit' ).size() == 0 )
8586 $( '#wikiEditor-' + context.instance + '-dialog-minor' ).hide();
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -9208,20 +9208,21 @@
92099209 });
92109210
92119211 // Reformat the copyright warning stuff
9212 - var copywarnHTML = $( '#editpage-copywarn' ).html();
 9212+ var copyWarnHTML = $( '#editpage-copywarn' ).html();
92139213
92149214 // TODO: internationalize by splitting on other characters that end statements
9215 - var copywarnStatements = copywarnHTML.split( '. ' );
9216 - for ( var i = 0; i < copywarnStatements.length; i++ ) {
9217 - if ( copywarnStatements[i] != '' ) {
9218 - newcopywarnHTML += '<li>' + copywarnStatements[i] + '. </li>';
 9215+ var copyWarnStatements = copyWarnHTML.split( '. ' );
 9216+ var newCopyWarnHTML = '';
 9217+ for ( var i = 0; i < copyWarnStatements.length; i++ ) {
 9218+ if ( copyWarnStatements[i] != '' ) {
 9219+ newCopyWarnHTML += '<li>' + copyWarnStatements[i] + '. </li>';
92199220 }
92209221 }
9221 - newcopywarnHTML += '</ul>';
 9222+ newCopyWarnHTML += '</ul>';
92229223
92239224 // No list if there's only one element
92249225 $(this).find( '.wikiEditor-dialog-copywarn' ).html(
9225 - copywarnStatements.length > 1 ? newcopywarnHTML : copywarnHTML );
 9226+ copyWarnStatements.length > 1 ? newCopyWarnHTML : copyWarnHTML );
92269227
92279228 if ( $( '#wpMinoredit' ).size() == 0 )
92289229 $( '#wikiEditor-' + context.instance + '-dialog-minor' ).hide();
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -639,8 +639,8 @@
640640 <label for="wikiEditor-'+context.instance+'-dialog-watch"\
641641 rel="wikieditor-publish-dialog-watch"></label>\
642642 </form>\
643 - </div>',init:function(){$(this).find('[rel]').each(function(){$(this).text(mw.usability.getMsg($(this).attr('rel')));});var copywarnHTML=$('#editpage-copywarn').html();var copywarnStatements=copywarnHTML.split('. ');for(var i=0;i<copywarnStatements.length;i++){if(copywarnStatements[i]!=''){newcopywarnHTML+='<li>'+copywarnStatements[i]+'. </li>';}}
644 -newcopywarnHTML+='</ul>';$(this).find('.wikiEditor-dialog-copywarn').html(copywarnStatements.length>1?newcopywarnHTML:copywarnHTML);if($('#wpMinoredit').size()==0)
 643+ </div>',init:function(){$(this).find('[rel]').each(function(){$(this).text(mw.usability.getMsg($(this).attr('rel')));});var copyWarnHTML=$('#editpage-copywarn').html();var copyWarnStatements=copyWarnHTML.split('. ');var newCopyWarnHTML='';for(var i=0;i<copyWarnStatements.length;i++){if(copyWarnStatements[i]!=''){newCopyWarnHTML+='<li>'+copyWarnStatements[i]+'. </li>';}}
 644+newCopyWarnHTML+='</ul>';$(this).find('.wikiEditor-dialog-copywarn').html(copyWarnStatements.length>1?newCopyWarnHTML:copyWarnHTML);if($('#wpMinoredit').size()==0)
645645 $('#wikiEditor-'+context.instance+'-dialog-minor').hide();else if($('#wpMinoredit').is(':checked'))
646646 $('#wikiEditor-'+context.instance+'-dialog-minor').attr('checked','checked');if($('#wpWatchthis').size()==0)
647647 $('#wikiEditor-'+context.instance+'-dialog-watch').hide();else if($('#wpWatchthis').is(':checked'))

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63825publish dialog looks less cluttered nownimishg19:38, 16 March 2010

Status & tagging log