r63858 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63857‎ | r63858 | r63859 >
Date:11:07, 17 March 2010
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: Revert unintended change to extension setup file in r63825, clean up whitespace. No functional changes so no style version bumps
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.publish.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.php
@@ -21,7 +21,7 @@
2222 /* Configuration */
2323
2424 // Set this to false to include all plugins individually
25 -$wgUsabilityInitiativeResourceMode = 'raw';
 25+$wgUsabilityInitiativeResourceMode = 'minified';
2626
2727 /* Setup */
2828
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.publish.js
@@ -64,20 +64,19 @@
6565 $(this).text( mw.usability.getMsg( $(this).attr( 'rel' ) ) );
6666 });
6767
68 - //reformat the copyright warning stuff
 68+ // Reformat the copyright warning stuff
6969 var copywarnHTML = $( '#editpage-copywarn' ).html();
7070
71 - //TODO: internationalize by splitting on other characters that end statements
72 - var copywarnStatements = copywarnHTML.split(". ");
73 - var newcopywarnHTML = "<ul>";
74 - for(var i = 0; i < copywarnStatements.length; i++){
75 - if(copywarnStatements[i] != ""){
76 - newcopywarnHTML += "<li>" + copywarnStatements[i] + ". </li>" ;
 71+ // TODO: internationalize by splitting on other characters that end statements
 72+ var copywarnStatements = copywarnHTML.split( '. ' );
 73+ for ( var i = 0; i < copywarnStatements.length; i++ ) {
 74+ if ( copywarnStatements[i] != '' ) {
 75+ newcopywarnHTML += '<li>' + copywarnStatements[i] + '. </li>';
7776 }
7877 }
79 - newcopywarnHTML += "</ul>";
 78+ newcopywarnHTML += '</ul>';
8079
81 - //no list if there's only one element
 80+ // No list if there's only one element
8281 $(this).find( '.wikiEditor-dialog-copywarn' ).html(
8382 copywarnStatements.length > 1 ? newcopywarnHTML : copywarnHTML );
8483
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -9206,20 +9206,19 @@
92079207 $(this).text( mw.usability.getMsg( $(this).attr( 'rel' ) ) );
92089208 });
92099209
9210 - //reformat the copyright warning stuff
 9210+ // Reformat the copyright warning stuff
92119211 var copywarnHTML = $( '#editpage-copywarn' ).html();
92129212
9213 - //TODO: internationalize by splitting on other characters that end statements
9214 - var copywarnStatements = copywarnHTML.split(". ");
9215 - var newcopywarnHTML = "<ul>";
9216 - for(var i = 0; i < copywarnStatements.length; i++){
9217 - if(copywarnStatements[i] != ""){
9218 - newcopywarnHTML += "<li>" + copywarnStatements[i] + ". </li>" ;
 9213+ // TODO: internationalize by splitting on other characters that end statements
 9214+ var copywarnStatements = copywarnHTML.split( '. ' );
 9215+ for ( var i = 0; i < copywarnStatements.length; i++ ) {
 9216+ if ( copywarnStatements[i] != '' ) {
 9217+ newcopywarnHTML += '<li>' + copywarnStatements[i] + '. </li>';
92199218 }
92209219 }
9221 - newcopywarnHTML += "</ul>";
 9220+ newcopywarnHTML += '</ul>';
92229221
9223 - //no list if there's only one element
 9222+ // No list if there's only one element
92249223 $(this).find( '.wikiEditor-dialog-copywarn' ).html(
92259224 copywarnStatements.length > 1 ? newcopywarnHTML : copywarnHTML );
92269225
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -639,8 +639,8 @@
640640 <label for="wikiEditor-'+context.instance+'-dialog-watch"\
641641 rel="wikieditor-publish-dialog-watch"></label>\
642642 </form>\
643 - </div>',init:function(){$(this).find('[rel]').each(function(){$(this).text(mw.usability.getMsg($(this).attr('rel')));});var copywarnHTML=$('#editpage-copywarn').html();var copywarnStatements=copywarnHTML.split(". ");var newcopywarnHTML="<ul>";for(var i=0;i<copywarnStatements.length;i++){if(copywarnStatements[i]!=""){newcopywarnHTML+="<li>"+copywarnStatements[i]+". </li>";}}
644 -newcopywarnHTML+="</ul>";$(this).find('.wikiEditor-dialog-copywarn').html(copywarnStatements.length>1?newcopywarnHTML:copywarnHTML);if($('#wpMinoredit').size()==0)
 643+ </div>',init:function(){$(this).find('[rel]').each(function(){$(this).text(mw.usability.getMsg($(this).attr('rel')));});var copywarnHTML=$('#editpage-copywarn').html();var copywarnStatements=copywarnHTML.split('. ');for(var i=0;i<copywarnStatements.length;i++){if(copywarnStatements[i]!=''){newcopywarnHTML+='<li>'+copywarnStatements[i]+'. </li>';}}
 644+newcopywarnHTML+='</ul>';$(this).find('.wikiEditor-dialog-copywarn').html(copywarnStatements.length>1?newcopywarnHTML:copywarnHTML);if($('#wpMinoredit').size()==0)
645645 $('#wikiEditor-'+context.instance+'-dialog-minor').hide();else if($('#wpMinoredit').is(':checked'))
646646 $('#wikiEditor-'+context.instance+'-dialog-minor').attr('checked','checked');if($('#wpWatchthis').size()==0)
647647 $('#wikiEditor-'+context.instance+'-dialog-watch').hide();else if($('#wpWatchthis').is(':checked'))

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63825publish dialog looks less cluttered nownimishg19:38, 16 March 2010

Status & tagging log