r63849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63848‎ | r63849 | r63850 >
Date:00:22, 17 March 2010
Author:dale
Status:deferred
Tags:
Comment:
* removed broad style
* fixed overlayControls check
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/skins/common/common.css (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js
@@ -600,11 +600,11 @@
601601 return false;
602602 }
603603 // If the config is false
604 - if( ! mw.getConfig( 'overlayControls' ) ){
 604+ if( mw.getConfig( 'overlayControls' ) === false){
605605 return false;
606606 }
607607 // If disabled via the player
608 - if( ! this.embedPlayer.overlayControls ){
 608+ if( this.embedPlayer.overlayControls === false ){
609609 return false;
610610 }
611611 // don't hide controls when content "height" is 0 ( audio tags )
Index: branches/js2-work/phase3/js/mwEmbed/skins/common/common.css
@@ -65,17 +65,9 @@
6666 width:16px;
6767 height:16px;
6868 }
69 -div.floatleft, table.floatleft {
70 - border:0pt none;
71 - clear:left;
72 - float:left;
73 - margin:0pt 0.5em 0.5em 0pt;
74 - position:relative;
75 -}
7669
7770
7871
79 -
8072 .large_play_button {
8173 display:block;
8274 width: 130px;

Status & tagging log