r63829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63828‎ | r63829 | r63830 >
Date:19:52, 16 March 2010
Author:aaron
Status:ok
Tags:
Comment:
Removed $wgFlaggedRevTabs. Always true now.
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -77,9 +77,6 @@
7878 # This will only distinguish "sigted", "quality", and unreviewed
7979 # A small icon will show in the upper right hand corner
8080 $wgSimpleFlaggedRevsUI = true;
81 -# Add stable/draft revision tabs. May be redundant due to the tags.
82 -# If you have an open wiki, with the simple UI, you may want to enable these.
83 -$wgFlaggedRevTabs = true;
8481 # For visitors, only show tags/icons for unreviewed/outdated pages
8582 $wgFlaggedRevsLowProfile = true;
8683
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -183,15 +183,6 @@
184184 global $wgFlaggedRevsAutoReviewNew;
185185 return (bool)$wgFlaggedRevsAutoReviewNew;
186186 }
187 -
188 - /**
189 - * Should pages have stable/draft tabs when not synced?
190 - * @returns bool
191 - */
192 - public static function versionTabsShown() {
193 - global $wgFlaggedRevTabs;
194 - return (bool)$wgFlaggedRevTabs;
195 - }
196187
197188 /**
198189 * Should this user see stable versions by default?
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -585,7 +585,7 @@
586586 if ( FlaggedRevs::forDefaultVersionOnly() ) {
587587 // If there is only on quality level and we have tabs to know
588588 // which version we are looking at, then just use the lock icon...
589 - return ( !FlaggedRevs::versionTabsShown() || FlaggedRevs::qualityVersions() );
 589+ return FlaggedRevs::qualityVersions();
590590 }
591591 return true;
592592 }
@@ -1035,7 +1035,7 @@
10361036 $views['viewsource']['text'] = wfMsg( 'revreview-source' );
10371037 }
10381038 }
1039 - if ( !FlaggedRevs::versionTabsShown() || $synced ) {
 1039+ if ( $synced ) {
10401040 // Exit, since either the draft tab should not be shown
10411041 // or the page is already the most current revision
10421042 return true;

Status & tagging log