r63826 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63825‎ | r63826 | r63827 >
Date:19:41, 16 March 2010
Author:mah
Status:deferred
Tags:
Comment:
Clean up build.xml
Modified paths:
  • /trunk/lucene-search-2/build.xml (modified) (history)

Diff [purge]

Index: trunk/lucene-search-2/build.xml
@@ -9,8 +9,11 @@
1010 <property name="src.name" value="lucene-search-src-2.1"/>
1111 <property name="binary.name" value="ls2.1-bin"/>
1212 <property name="jar.name" value="LuceneSearch.jar"/>
13 - <property name="include" value="src/** lib/** sql/** test-data/** webinterface/** *-example *.txt lsearch* build.xml scripts/* VERSION configure build update resources/** test/** udplogger/**"/>
14 - <property name="include.src" value="src/** sql/** build.xml scripts/* webinterface/* VERSION configure build update test/** udplogger/**"/>
 13+ <property name="include" value="src/** lib/** sql/** test-data/** webinterface/** *-example *.txt
 14+ lsearch* build.xml scripts/* VERSION configure build update
 15+ resources/** test/** udplogger/**"/>
 16+ <property name="include.src" value="src/** sql/** build.xml scripts/* webinterface/* VERSION
 17+ configure build update test/** udplogger/**"/>
1518 <property name="include.bin" value="*.log4j *.txt config.inc template/** udplogger/**"/>
1619 <property name="include.sh" value="configure build update lsearchd"/>
1720
@@ -24,20 +27,25 @@
2528 <java jar="${jar.name}" fork="yes">
2629 <sysproperty key="java.rmi.server.codebase" value="file://${basedir}/${jar.name}"/>
2730 <sysproperty key="java.rmi.server.hostname" value="${hostname}"/>
28 - <classpath>
29 - <fileset dir="${lib}">
30 - <include name="*.jar"/>
31 - </fileset>
32 - </classpath>
33 - </java>
34 - </target>
 31+ <classpath>
 32+ <fileset dir="${lib}">
 33+ <include name="*.jar"/>
 34+ </fileset>
 35+ </classpath>
 36+ </java>
 37+ </target>
3538
3639 <target name="makejar" depends="build">
3740 <jar destfile="${basedir}/${jar.name}">
3841 <manifest>
39 - <attribute name="Main-Class" value="org.wikimedia.lsearch.config.StartupManager"/>
40 - <attribute name="Class-Path" value="${jar.name} lib/xmlrpc-common-3.0.jar lib/xmlrpc-client-3.0.jar lib/xmlrpc-server-3.0.jar lib/commons-logging-1.1.jar lib/ws-commons-util-1.0.1.jar lib/log4j-1.2.14.jar lib/lucene-core-2.3.jar lib/lucene-analyzers.jar lib/snowball.jar lib/mwdumper.jar lib/mysql-connector-java-3.0.17-ga-bin.jar"/>
41 - </manifest>
 42+ <attribute name="Main-Class" value="org.wikimedia.lsearch.config.StartupManager"/>
 43+ <attribute name="Class-Path" value="${jar.name} lib/xmlrpc-common-3.0.jar
 44+ lib/xmlrpc-client-3.0.jar lib/xmlrpc-server-3.0.jar
 45+ lib/commons-logging-1.1.jar lib/ws-commons-util-1.0.1.jar
 46+ lib/log4j-1.2.14.jar lib/lucene-core-2.3.jar
 47+ lib/lucene-analyzers.jar lib/snowball.jar lib/mwdumper.jar
 48+ lib/mysql-connector-java-3.0.17-ga-bin.jar"/>
 49+ </manifest>
4250 <zipfileset dir="${bin}" prefix="">
4351 <include name="org/**"/>
4452 </zipfileset>
@@ -70,11 +78,11 @@
7179
7280
7381 <target name="build" description="Compile classes">
74 - <mkdir dir="${bin}"/>
75 - <javac srcdir="${src}/org/" debug="on" encoding="UTF-8" includes="**/*.java" destdir="${bin}/">
76 - <classpath refid="classpath"/>
77 - </javac>
78 - </target>
 82+ <mkdir dir="${bin}"/>
 83+ <javac srcdir="${src}/org/" debug="on" encoding="UTF-8" includes="**/*.java" destdir="${bin}/">
 84+ <classpath refid="classpath"/>
 85+ </javac>
 86+ </target>
7987
8088 <target name="pack" description="Make tar.gz distribution">
8189 <mkdir dir="${dist}"/>
@@ -106,7 +114,8 @@
107115 <delete file="${dist}/${binary.name}.tar"/>
108116 <delete file="${dist}/${binary.name}.tar.gz"/>
109117 <tar tarfile="${dist}/${binary.name}.tar">
110 - <tarfileset prefix="${pack.name}" dir="." includes="${jar.name} ${include.bin}" excludes="template/backup/**"/>
 118+ <tarfileset prefix="${pack.name}" dir="." includes="${jar.name} ${include.bin}"
 119+ excludes="template/backup/**"/>
111120 <tarfileset prefix="${pack.name}" mode="755" dir="." includes="${include.sh}"/>
112121 </tar>
113122

Status & tagging log