Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php |
— | — | @@ -939,7 +939,7 @@ |
940 | 940 | : FlaggedRevision::newFromTitle( $title, $baseRevId, FR_MASTER ); |
941 | 941 | } |
942 | 942 | // Is this an edit directly to the stable version? Is it a new page? |
943 | | - if ( $isAllowed && ( $reviewableNewPage || !is_null( $frev ) ) ) { |
| 943 | + if ( $isAllowed && ( $reviewableNewPage || $frev ) ) { |
944 | 944 | if ( $isNullEdit && $frev ) { |
945 | 945 | $flags = $frev->getTags(); // Dummy edits always keep previous tags |
946 | 946 | } |
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php |
— | — | @@ -144,7 +144,7 @@ |
145 | 145 | $revID = $this->article->getOldIDFromRequest(); |
146 | 146 | $frev = FlaggedRevision::newFromTitle( $this->article->getTitle(), $revID ); |
147 | 147 | # Give a notice if this rev ID corresponds to a reviewed version... |
148 | | - if ( !is_null( $frev ) ) { |
| 148 | + if ( $frev ) { |
149 | 149 | $time = $wgLang->date( $frev->getTimestamp(), true ); |
150 | 150 | $flags = $frev->getTags(); |
151 | 151 | $quality = FlaggedRevs::isQuality( $flags ); |
— | — | @@ -231,7 +231,7 @@ |
232 | 232 | // Is the page config altered? |
233 | 233 | $prot = FlaggedRevsXML::lockStatusIcon( $this->article ); |
234 | 234 | // Is there no stable version? |
235 | | - if ( is_null( $frev ) ) { |
| 235 | + if ( !$frev ) { |
236 | 236 | # Add "no reviewed version" tag, but not for printable output |
237 | 237 | $this->showUnreviewedPage( $tag, $prot ); |
238 | 238 | return true; |
— | — | @@ -680,7 +680,7 @@ |
681 | 681 | } elseif ( $this->pageOverride() ) { |
682 | 682 | $frev = $this->article->getStableRev(); |
683 | 683 | } |
684 | | - if ( !is_null( $frev ) ) { |
| 684 | + if ( $frev ) { |
685 | 685 | $time = $frev->getFileTimestamp(); |
686 | 686 | // B/C, may be stored in associated image version metadata table |
687 | 687 | if ( !$time ) { |