r63811 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63810‎ | r63811 | r63812 >
Date:10:13, 16 March 2010
Author:jojo
Status:deferred
Tags:
Comment:
merge fixes from trunk
Modified paths:
  • /branches/REL1_16/extensions/Collection (modified) (history)
  • /branches/REL1_16/extensions/Collection/Collection.body.php (modified) (history)
  • /branches/REL1_16/extensions/Collection/Collection.i18n.php (modified) (history)
  • /branches/REL1_16/extensions/Collection/CollectionCore.i18n.php (modified) (history)
  • /branches/REL1_16/extensions/Collection/js/bookcreator.js (modified) (history)

Diff [purge]

Index: branches/REL1_16/extensions/Collection/Collection.i18n.php
@@ -1130,8 +1130,8 @@
11311131 'coll-savedbook_template' => 'levr enrollet',
11321132 'coll-your_book' => 'Ho levr',
11331133 'coll-download_title' => 'Pellgargañ',
1134 - 'coll-download_text' => 'A-benn pellgargañ ho levr, dibabit ur furmad ha klikit war ar bouton.',
1135 - 'coll-download_as_text' => 'A-benn pellgargañ ur stumm eus o levr er furmad $1, klikit war ar bouton.',
 1134+ 'coll-download_text' => 'Evit pellgargañ ho levr, dibabit ur furmad ha klikit war ar bouton.',
 1135+ 'coll-download_as_text' => 'Evit pellgargañ ho levr er furmad $1, klikit war ar bouton.',
11361136 'coll-download' => 'Pellgargañ',
11371137 'coll-format_label' => 'Furmad :',
11381138 'coll-remove' => 'Lemel kuit',
@@ -1164,7 +1164,7 @@
11651165 'coll-personal_collection_label' => 'Levr personel',
11661166 'coll-community_collection_label' => 'Levr eus ar gumuniezh',
11671167 'coll-save_collection' => 'Enrollañ al levr',
1168 - 'coll-save_category' => 'Enrollet eo an holl levrioù er rummad [[:Category:{{MediaWiki:Coll-bookscategory}}|{{MediaWiki:Coll-bookscategory}}]].',
 1168+ 'coll-save_category' => 'Emañ renket an holl levrioù enrollet er rummad [[:Category:{{MediaWiki:Coll-bookscategory}}|{{MediaWiki:Coll-bookscategory}}]].',
11691169 'coll-overwrite_title' => "Bez'ez eus eus ar bajenn c'hoazh.
11701170 Skrivañ war-c'horre ?",
11711171 'coll-overwrite_text' => "Ur bajenn dezhi an anv [[:$1]] zo dija.
Index: branches/REL1_16/extensions/Collection/CollectionCore.i18n.php
@@ -464,6 +464,8 @@
465465 'coll-disable' => 'vypnout',
466466 'coll-book_creator_disable' => 'Vypnout editor knih',
467467 'coll-book_creator_disable_tooltip' => 'Přestane s používáním editoru knih',
 468+ 'coll-add_linked_article' => 'Přidat odkazovanou stránku wiki do knihy',
 469+ 'coll-remove_linked_article' => 'Odebrat odkazovanou stránku wiki z knihy',
468470 'coll-add_category' => 'Přidat tuto kategorii do vaší knihy',
469471 'coll-add_category_tooltip' => 'Přidá všechny stránky wiki v této kategorii do vaší knihy',
470472 'coll-add_this_page' => 'Přidat tuto stránku do vaší knihy',
@@ -581,6 +583,8 @@
582584 'coll-disable' => 'deaktivieren',
583585 'coll-book_creator_disable' => 'Buchgenerator deaktivieren',
584586 'coll-book_creator_disable_tooltip' => 'Buchgenerator nicht verwenden',
 587+ 'coll-add_linked_article' => 'Füge die verlinkte Wikiseite deinem Buch hinzu',
 588+ 'coll-remove_linked_article' => 'Entferne die verlinkte Wikiseite aus deinem Buch',
585589 'coll-add_category' => 'Alle Seiten aus dieser Kategorie deinem Buch hinzufügen',
586590 'coll-add_category_tooltip' => 'Alle Wikiseiten dieser Kategorie deinem Buch hinzufügen',
587591 'coll-add_this_page' => 'Diese Seite zu deinem Buch hinzufügen',
@@ -951,6 +955,7 @@
952956 * @author Grondin
953957 * @author Guillom
954958 * @author IAlex
 959+ * @author Jean-Frédéric
955960 * @author McDutchie
956961 * @author Meithal
957962 * @author PieRRoMaN
@@ -966,6 +971,8 @@
967972 'coll-disable' => 'désactiver',
968973 'coll-book_creator_disable' => 'Désactiver le créateur de livre',
969974 'coll-book_creator_disable_tooltip' => "Cesser d'utiliser le créateur de livre",
 975+ 'coll-add_linked_article' => 'Ajouter la page wiki liée à votre livre',
 976+ 'coll-remove_linked_article' => 'Retirer la page wiki liée de votre livre',
970977 'coll-add_category' => 'Ajouter cette catégorie à votre livre',
971978 'coll-add_category_tooltip' => 'Ajouter tous les articles de cette catégorie à votre livre',
972979 'coll-add_this_page' => 'Ajouter cette page à votre livre',
@@ -1043,6 +1050,8 @@
10441051 'coll-disable' => 'desactivar',
10451052 'coll-book_creator_disable' => 'Desactivar o creador de libros',
10461053 'coll-book_creator_disable_tooltip' => 'Deixar de usar o creador de libros',
 1054+ 'coll-add_linked_article' => 'Engadir a páxina wiki ligada ao seu libro',
 1055+ 'coll-remove_linked_article' => 'Eliminar a páxina wiki ligada do seu libro',
10471056 'coll-add_category' => 'Engadir esta categoría ao seu libro',
10481057 'coll-add_category_tooltip' => 'Engadir todas as páxinas wiki desta categoría ao seu libro',
10491058 'coll-add_this_page' => 'Engadir esta páxina ao seu libro',
@@ -1231,6 +1240,8 @@
12321241 'coll-disable' => 'znjemóžnić',
12331242 'coll-book_creator_disable' => 'Generator knihow znjemóžnić',
12341243 'coll-book_creator_disable_tooltip' => 'Wužiwanje generatora knihow zastajić',
 1244+ 'coll-add_linked_article' => 'Wotkazanu wikistronu twojej knize přidać',
 1245+ 'coll-remove_linked_article' => 'Wotkazanu wikistronu z twojeje knihi wotstronić',
12351246 'coll-add_category' => 'Tutu kategoriju twojej knize přidać',
12361247 'coll-add_category_tooltip' => 'Wšě wikistrony w tutej kategoriji twojej knize přidać',
12371248 'coll-add_this_page' => 'Tutu stronu twojej knize přidać',
@@ -1658,6 +1669,7 @@
16591670 );
16601671
16611672 /** Luxembourgish (Lëtzebuergesch)
 1673+ * @author Les Meloures
16621674 * @author Robby
16631675 */
16641676 $messages['lb'] = array(
@@ -1669,7 +1681,9 @@
16701682 'coll-download_as_tooltip' => 'Eng $1 Versioun vun dëser Wiki-Säit eroflueden',
16711683 'coll-disable' => 'Ausschalten',
16721684 'coll-book_creator_disable' => 'Buchfonctioun ausschalten',
1673 - 'coll-book_creator_disable_tooltip' => "Ophalen d'buchfonctioun ze benotzen",
 1685+ 'coll-book_creator_disable_tooltip' => "Ophalen d'Buchfonctioun ze benotzen",
 1686+ 'coll-add_linked_article' => 'Déi verlinkte Wiki-Säit an däi buch derbäisetzen',
 1687+ 'coll-remove_linked_article' => 'Déi verlinkte Wiki-Säit aus dengem Buch eraushuelen',
16741688 'coll-add_category' => 'Dës Kategorie an Ärt Buch derbäisetzen',
16751689 'coll-add_category_tooltip' => 'All Wiki-Säiten aus dëser Kategorie an Ärt Buch derbäisetzen',
16761690 'coll-add_this_page' => 'Dës Säit an Ärt Buch derbäisetzen',
@@ -1740,6 +1754,8 @@
17411755 'coll-disable' => 'оневозможи',
17421756 'coll-book_creator_disable' => 'Оневозможи ја книговезницата',
17431757 'coll-book_creator_disable_tooltip' => 'Прекини со користење на книговезницата',
 1758+ 'coll-add_linked_article' => 'Додавај врска до викистраница во книгата',
 1759+ 'coll-remove_linked_article' => 'Отстрани врска до викистраница од книгата',
17441760 'coll-add_category' => 'Додајте ја категоријава во вашата книга',
17451761 'coll-add_category_tooltip' => 'Додај ги сите вики-страници од оваа категорија во книгата',
17461762 'coll-add_this_page' => 'Додај ја страницава во мојата книга',
@@ -1906,6 +1922,7 @@
19071923 );
19081924
19091925 /** Dutch (Nederlands)
 1926+ * @author McDutchie
19101927 * @author Siebrand
19111928 * @author Tvdm
19121929 */
@@ -1919,6 +1936,8 @@
19201937 'coll-disable' => 'uitschakelen',
19211938 'coll-book_creator_disable' => 'Boekenmaker uitschakelen',
19221939 'coll-book_creator_disable_tooltip' => 'Boekenmaker niet meer gebruiken',
 1940+ 'coll-add_linked_article' => 'De gekoppelde wikipagina aan uw boek toevoegen',
 1941+ 'coll-remove_linked_article' => 'De gekoppelde wikipagina uit uw boek verwijderen',
19231942 'coll-add_category' => 'Deze categorie aan uw boek toevoegen',
19241943 'coll-add_category_tooltip' => "Alle pagina's in deze categorie aan uw boek toevoegen",
19251944 'coll-add_this_page' => 'Deze pagina aan uw boek toevoegen',
@@ -2335,6 +2354,8 @@
23362355 'coll-disable' => 'выключить',
23372356 'coll-book_creator_disable' => 'Отключить книжного мастера',
23382357 'coll-book_creator_disable_tooltip' => 'Прекратите использование книжного мастера',
 2358+ 'coll-add_linked_article' => 'Добавить связанную вики-страницу в вашу книгу',
 2359+ 'coll-remove_linked_article' => 'Удалить связанную вики-страницу из вашей книги',
23392360 'coll-add_category' => 'Добавить эту категорию в вашу книгу',
23402361 'coll-add_category_tooltip' => 'Добавить все вики-страницы этой категории в книгу',
23412362 'coll-add_this_page' => 'Добавить эту страницу в вашу книгу',
@@ -2742,6 +2763,8 @@
27432764 'coll-disable' => 'devre dışı bırak',
27442765 'coll-book_creator_disable' => 'Koleksiyon oluşturucuyu devre dışı bırak',
27452766 'coll-book_creator_disable_tooltip' => 'Koleksiyon oluşturucuyu kullanmayı bırak',
 2767+ 'coll-add_linked_article' => 'Bağlantılı viki sayfasını kitabınıza ekleyin',
 2768+ 'coll-remove_linked_article' => 'Bağlantılı viki sayfasını kitabınızdan çıkarın',
27462769 'coll-add_category' => 'Bu kategoriyi kitabınıza ekleyin',
27472770 'coll-add_category_tooltip' => 'Bu kategorideki tüm viki sayfalarını koleksiyonunuza ekleyin',
27482771 'coll-add_this_page' => 'Bu sayfayı koleksiyonunuza ekleyin',
Index: branches/REL1_16/extensions/Collection/js/bookcreator.js
@@ -19,13 +19,8 @@
2020 * http://www.gnu.org/copyleft/gpl.html
2121 */
2222
23 -(function() {
 23+(function($) {
2424
25 -var $ = window.$;
26 -if (typeof $ == 'undefined') {
27 - $ = jQuery;
28 -}
29 -
3025 function refreshBookCreatorBox(hint, oldid) {
3126 sajax_request_type = 'GET';
3227 sajax_do_call('wfAjaxCollectionGetBookCreatorBoxContent', [hint, oldid], function(xhr) {
@@ -177,4 +172,4 @@
178173 });
179174 });
180175
181 -})();
 176+})(jQuery);
Index: branches/REL1_16/extensions/Collection/Collection.body.php
@@ -736,7 +736,7 @@
737737 );
738738 } elseif ( substr( $line, 0, 1 ) == ':' ) { // article
739739 $articleTitle = trim( substr( $line, 1 ) );
740 - if ( preg_match( '/\[\[:?(.*?)(\|(.*?))?\]\]/', $articleTitle, $match ) ) {
 740+ if ( preg_match( '/^\[\[:?(.*?)(\|(.*?))?\]\]$/', $articleTitle, $match ) ) {
741741 $articleTitle = $match[1];
742742 if ( isset( $match[3] ) ) {
743743 $displayTitle = $match[3];
@@ -745,7 +745,7 @@
746746 }
747747 $oldid = -1;
748748 $currentVersion = 1;
749 - } elseif ( preg_match( '/\[\{\{fullurl:(.*?)\|oldid=(.*?)\}\}\s+(.*?)\]/', $articleTitle, $match ) ) {
 749+ } elseif ( preg_match( '/^\[\{\{fullurl:(.*?)\|oldid=(.*?)\}\}\s+(.*?)\]$/', $articleTitle, $match ) ) {
750750 $articleTitle = $match[1];
751751 if ( isset( $match[3] ) ) {
752752 $displayTitle = $match[3];
@@ -754,6 +754,8 @@
755755 }
756756 $oldid = $match[2];
757757 $currentVersion = 0;
 758+ } else {
 759+ return null;
758760 }
759761
760762 $articleTitle = Title::newFromText( $articleTitle );
@@ -794,6 +796,7 @@
795797
796798 function loadCollection( $title, $append=false ) {
797799 global $wgOut;
 800+
798801 if ( is_null( $title ) ) {
799802 $wgOut->showErrorPage( 'coll-notitle_title', 'coll-notitle_msg' );
800803 return;
@@ -815,6 +818,8 @@
816819 $items = $collection['items'];
817820 }
818821
 822+ $article = new Article( $title );
 823+
819824 foreach( preg_split( '/[\r\n]+/', $article->getContent() ) as $line ) {
820825 $item = $this->parseCollectionLine( $collection, $line, $append );
821826 if ( !is_null( $item ) ) {
Property changes on: branches/REL1_16/extensions/Collection
___________________________________________________________________
Name: svn:mergeinfo
822827 - /trunk/extensions/Collection:62820-63596
823828 + /trunk/extensions/Collection:62820-63810

Status & tagging log