r63805 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63804‎ | r63805 | r63806 >
Date:06:16, 16 March 2010
Author:dale
Status:deferred
Tags:
Comment:
a few more display tweeks and bad mime support
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/mw.EmbedPlayer.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/skins/mvpcf/EmbedPlayer.css (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/skins/mvpcf/EmbedPlayer.css
@@ -4,8 +4,8 @@
55
66 /*Video player*/
77 .mv-player {
8 - color: #000;
9 - background: #FFF;
 8+ color: #FFF;
 9+ background: #000;
1010 }
1111
1212 /* large play button: */
Index: branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/mw.EmbedPlayer.js
@@ -609,6 +609,14 @@
610610 this.mimeType = this.detectType( this.src );
611611 }
612612
 613+ // Conform the mime type to ogg
 614+ if( this.mimeType == 'video/theora') {
 615+ this.mimeType = 'video/ogg';
 616+ }
 617+
 618+ if( this.mimeType == 'audio/vorbis') {
 619+ this.mimeType = 'audio/ogg';
 620+ }
613621
614622 // Check for parent elements ( supplies categories in "itext" )
615623 if( $j( element ).parent().attr('category') ) {
@@ -2357,7 +2365,7 @@
23582366 })
23592367 );
23602368
2361 - if ( this.controls == true
 2369+ if ( this.controls
23622370 && this.height > this.ctrlBuilder.getComponentHeight( 'playButtonLarge' )
23632371 ) {
23642372 $j( this ).append(

Status & tagging log