r63771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63770‎ | r63771 | r63772 >
Date:13:50, 15 March 2010
Author:demon
Status:ok
Tags:
Comment:
Accept any bug, not only those in (bug 123) format, just like $wgThings.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -1601,7 +1601,7 @@
16021602 $text = preg_replace( "/\n([\\*#])([^\r\n]*?)\r?\n([^\r\n#\\*:]+)/", "\n\\1\\2 \\3", $text );
16031603 } while ( $text != $prev );
16041604 // turn (bug nnnn) into links
1605 - $text = preg_replace_callback('/\(bug (\d+)\)/', array( $this, 'replaceBugLinks' ), $text );
 1605+ $text = preg_replace_callback('/bug (\d+)/', array( $this, 'replaceBugLinks' ), $text );
16061606 // add links to manual to every global variable mentioned
16071607 $text = preg_replace_callback('/(\$wg[a-z0-9_]+)/i', array( $this, 'replaceConfigLinks' ), $text );
16081608 // special case for <pre> - formatted links
@@ -1613,8 +1613,8 @@
16141614 }
16151615
16161616 private function replaceBugLinks( $matches ) {
1617 - return '(<span class="config-plainlink">[https://bugzilla.wikimedia.org/show_bug.cgi?id=' .
1618 - $matches[1] . ' bug ' . $matches[1] . ']</span>)';
 1617+ return '<span class="config-plainlink">[https://bugzilla.wikimedia.org/' .
 1618+ $matches[1] . ' bug ' . $matches[1] . ']</span>';
16191619 }
16201620
16211621 private function replaceConfigLinks( $matches ) {

Status & tagging log