r63754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63753‎ | r63754 | r63755 >
Date:18:15, 14 March 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Stylized with Stylize.php to conform with MW's spacing conventions
Modified paths:
  • /trunk/extensions/SemanticTasks/ST_CheckForReminders.php (modified) (history)
  • /trunk/extensions/SemanticTasks/SemanticTasks.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticTasks/ST_CheckForReminders.php
@@ -8,7 +8,7 @@
99 global $smwgIP;
1010 require_once( $smwgIP . '/includes/SMW_Factbox.php' );
1111
12 -require_once( dirname(__FILE__) . '/SemanticTasks.classes.php' );
 12+require_once( dirname( __FILE__ ) . '/SemanticTasks.classes.php' );
1313
1414 // Let's send reminders
1515 SemanticTasksMailer::remindAssignees( 'http://teamspace.creativecommons.org/' );
Index: trunk/extensions/SemanticTasks/SemanticTasks.classes.php
@@ -1,10 +1,10 @@
22 <?php
33
4 -//constants for message type
5 -define("NEWTASK", 0);
6 -define("UPDATE", 1);
7 -define("ASSIGNED", 2);
8 -define("CLOSED", 3);
 4+// constants for message type
 5+define( "NEWTASK", 0 );
 6+define( "UPDATE", 1 );
 7+define( "ASSIGNED", 2 );
 8+define( "CLOSED", 3 );
99
1010 /**
1111 * This class handles the creation and sending of notification emails.
@@ -231,11 +231,11 @@
232232 foreach ( $assignees as $assignee_name ) {
233233 $assignee = User::newFromName( $assignee_name );
234234 // if assignee is the current user, do nothing
235 - #if ( $assignee->getID() != $user->getID() ) {
 235+ # if ( $assignee->getID() != $user->getID() ) {
236236 $assignee_mail = new MailAddress( $assignee->getEmail(), $assignee_name );
237237 array_push( $assignee_arr, $assignee_mail );
238238 self::printDebug( $assignee_name );
239 - #}
 239+ # }
240240 }
241241
242242 return $assignee_arr;
@@ -271,7 +271,7 @@
272272 $body = wfMsg( $message , $title_text ) . " " . $link;
273273 $body .= "\n \n" . wfMsg( 'semantictasks-text-message' ) . "\n" . $text;
274274 } else {
275 - //status == ASSIGNED
 275+ // status == ASSIGNED
276276 $subject = '[' . $wgSitename . '] ' . wfMsg( 'semantictasks-taskassigned' ) . ' ' . $title_text;
277277 $message = 'semantictasks-assignedtoyou-msg2';
278278 $body = wfMsg( $message , $title_text ) . " " . $link;

Status & tagging log