r63705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63704‎ | r63705 | r63706 >
Date:20:42, 13 March 2010
Author:demon
Status:ok
Tags:
Comment:
Remove duplicate message config-upgrade-done, redo installation complete message like upgrade complete message. Got rid of unused config-install-failed.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/new-installer/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/maintenance/language/messages.inc
@@ -3355,8 +3355,6 @@
33563356 'config-install-user',
33573357 'config-install-localsettings',
33583358 'config-install-done',
3359 - 'config-install-failed',
3360 - 'config-upgrade-done',
33613359 ),
33623360 );
33633361
Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -1531,8 +1531,6 @@
15321532 $localSettings->writeLocalSettings();
15331533 $this->endStage();
15341534
1535 - $this->parent->setVar( '_InstallStatus', 'installed' );
1536 -
15371535 $this->endForm();
15381536 }
15391537
@@ -1546,18 +1544,16 @@
15471545 }
15481546 class WebInstaller_Complete extends WebInstallerPage {
15491547 public function execute() {
1550 - $status = $this->parent->getVar( '_InstallStatus' );
15511548 $this->startForm();
1552 - if( $status === 'installed' ) {
1553 - $msg = 'config-install-done';
1554 - } elseif( $status === 'upgraded' ) {
1555 - $msg = 'config-upgrade-done';
1556 - } else {
1557 - $msg = 'config-install-failed';
1558 - }
1559 - global $wgServer;
1560 - $url = $wgServer . preg_replace( "/config\/[a-z\-]+\.php5?/i", '', $this->parent->getUrl() );
1561 - $this->parent->output->addWikiText( wfMsg( $msg, $url ) );
 1549+ $this->parent->output->addHTML(
 1550+ $this->parent->getInfoBox(
 1551+ wfMsgNoTrans( 'config-install-done',
 1552+ $GLOBALS['wgServer'] .
 1553+ $this->getVar( 'wgScriptPath' ) . '/index' .
 1554+ $this->getVar( 'wgScriptExtension' )
 1555+ ), 'tick-32.png'
 1556+ )
 1557+ );
15621558 $this->endForm( false );
15631559 }
15641560 }
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -70,7 +70,6 @@
7171 '_CCDone' => false,
7272 '_Extensions' => array(),
7373 '_MemCachedServers' => '',
74 - '_InstallStatus' => false,
7574 );
7675
7776 /**
Index: branches/new-installer/phase3/languages/messages/MessagesEn.php
@@ -4462,14 +4462,7 @@
44634463 for MediaWiki to begin working.
44644464
44654465 [$1 Link to your wiki]",
4466 -'config-install-failed' => "'''Sorry''', something in the installation process seems to have gone horribly wrong.",
4467 -'config-upgrade-done' => "'''Congratulations''', you have successfully upgraded MediaWiki.
44684466
4469 -If you chose to overwrite your LocalSettings.php file, you will need to move it from <tt>./config/LocalSettings.php</tt>
4470 -to <tt>./LocalSettings.php</tt>.
4471 -
4472 -[$1 Link to your wiki]",
4473 -
44744467 # Special:Version
44754468 'version' => 'Version',
44764469 'version-extensions' => 'Installed extensions',

Status & tagging log