r63691 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63690‎ | r63691 | r63692 >
Date:17:23, 13 March 2010
Author:raymond
Status:ok
Tags:
Comment:
Use commaList() for better i18n
Modified paths:
  • /trunk/extensions/AbuseFilter/SpecialAbuseLog.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewRevert.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/SpecialAbuseLog.php
@@ -265,7 +265,7 @@
266266 foreach ( $actions as $action ) {
267267 $displayActions[] = AbuseFilter::getActionDisplay( $action );
268268 }
269 - $actions_taken = implode( ', ', $displayActions );
 269+ $actions_taken = $wgLang->commaList( $displayActions );
270270 }
271271
272272 $globalIndex = AbuseFilter::decodeGlobalName( $row->afl_filter );
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php
@@ -215,7 +215,7 @@
216216 foreach ( $actions as $action ) {
217217 $displayActions[] = AbuseFilter::getActionDisplay( $action ); ;
218218 }
219 - return htmlspecialchars( implode( ', ', $displayActions ) );
 219+ return htmlspecialchars( $wgLang->commaList( $displayActions ) );
220220 case 'af_enabled':
221221 $statuses = array();
222222 if ( $row->af_deleted )
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewRevert.php
@@ -70,7 +70,7 @@
7171 $sk->userLink( $result['userid'], $result['user'] ),
7272 $result['action'],
7373 $sk->link( $result['title'] ),
74 - implode( ', ', $displayActions ),
 74+ $wgLang->commaList( $displayActions ),
7575 $sk->link(
7676 SpecialPage::getTitleFor( 'AbuseLog' ),
7777 wfMsgNoTrans( 'abusefilter-log-detailslink' ),

Status & tagging log