r63684 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63683‎ | r63684 | r63685 >
Date:16:11, 13 March 2010
Author:happy-melon
Status:ok
Tags:
Comment:
Strict type checking, otherwise can't set a default value of '0'.
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -744,7 +744,7 @@
745745 public function __construct( $name = false, $id = false, $default = false ) {
746746 if ( $name ) $this->setAttribute( 'name', $name );
747747 if ( $id ) $this->setAttribute( 'id', $id );
748 - if ( $default ) $this->default = $default;
 748+ if ( $default !== false ) $this->default = $default;
749749 }
750750
751751 public function setDefault( $default ) {

Status & tagging log