r63678 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63677‎ | r63678 | r63679 >
Date:15:35, 13 March 2010
Author:happy-melon
Status:ok
Tags:
Comment:
Add FIXME to wfMergeErrorArrays(), throws E_NOTICEs.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2580,11 +2580,13 @@
25812581 * array( 'y' )
25822582 * )
25832583 */
2584 -function wfMergeErrorArrays(/*...*/) {
 2584+function wfMergeErrorArrays( /*...*/ ) {
25852585 $args = func_get_args();
25862586 $out = array();
25872587 foreach ( $args as $errors ) {
25882588 foreach ( $errors as $params ) {
 2589+ # FIXME: sometimes get nested arrays for $params,
 2590+ # which leads to E_NOTICEs
25892591 $spec = implode( "\t", $params );
25902592 $out[$spec] = $params;
25912593 }

Status & tagging log