r63595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63594‎ | r63595 | r63596 >
Date:11:54, 11 March 2010
Author:jojo
Status:ok
Tags:
Comment:
make test explicit b/c it somehow does not work always as selector
Modified paths:
  • /trunk/extensions/Collection/js/bookcreator.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/js/bookcreator.js
@@ -157,7 +157,6 @@
158158 + 'a[href^=' + prefix + ']' // URL starts with prefix of wgArticlePath
159159 + ':not(a[href~=index.php])' // URL doesn't contain index.php (simplification!)
160160 + '[title!=]' // title attribute is not empty
161 - + ':not([title~=:])' // title doesn't contain a ':' (simplification!)
162161 + '[rel!=nofollow]'
163162 + ':not(.external)'
164163 + ':not(.sortheader)'
@@ -168,6 +167,9 @@
169168 return;
170169 }
171170 var $this = $(this);
 171+ if ($this.attr('title').indexOf(':') != -1) { // title doesn't contain ":" (simplification!)
 172+ return;
 173+ }
172174 if ($this.parents('.nopopups').length) {
173175 return;
174176 }

Status & tagging log