r63588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63587‎ | r63588 | r63589 >
Date:08:41, 11 March 2010
Author:aaron
Status:ok
Tags:
Comment:
Hide tag clutter from box for binaryFlagging case
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevsXML.php
@@ -239,8 +239,11 @@
240240 $box .= "<td style='text-align:right;'>" . self::ratingToggle() . "</td></tr>\n";
241241 $box .= "<tr><td id='mw-fr-revisionratings'>$html<br />";
242242 # Add any rating tags as needed...
243 - if ( $flags && ( $type == 'stable' || $type == 'oldstable' ) ) {
244 - $box .= self::addTagRatings( $flags, true, $color );
 243+ if( $flags && !FlaggedRevs::binaryFlagging() ) {
 244+ # Don't show the ratings on draft views
 245+ if ( $type == 'stable' || $type == 'oldstable' ) {
 246+ $box .= self::addTagRatings( $flags, true, $color );
 247+ }
245248 }
246249 $box .= "</td><td></td></tr></table>";
247250 return $box;

Status & tagging log