r63508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63507‎ | r63508 | r63509 >
Date:21:24, 9 March 2010
Author:yaron
Status:deferred
Tags:
Comment:
Renamed a number of language values
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormEditPage.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormEditTab.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.inc (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.inc (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_FormStart.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormStart.php
@@ -93,7 +93,7 @@
9494 $description = wfMsg('sf_formstart_noform_docu', $form_name);
9595 else
9696 $description = wfMsg('sf_formstart_docu', $form_name);
97 - $button_text = wfMsg('addoreditdata');
 97+ $button_text = wfMsg('createoredit');
9898 $text =<<<END
9999 <form action="" method="post">
100100 <p>$description</p>
Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -60,7 +60,7 @@
6161 // get contents of form and target page - if there's only one,
6262 // it might be a target with only alternate forms
6363 if ($form_name == '') {
64 - $wgOut->addHTML( "<p class='error'>" . wfMsg('sf_adddata_badurl') . '</p>');
 64+ $wgOut->addHTML( "<p class='error'>" . wfMsg('sf_formedit_badurl') . '</p>');
6565 return;
6666 } elseif ($target_name == '') {
6767 // parse the form to see if it has a 'page name' value set
@@ -77,7 +77,7 @@
7878 $page_name_formula = substr($page_name_formula, 0, $pos);
7979 }
8080 } elseif (count($alt_forms) == 0) {
81 - $wgOut->addWikiText( "<p class='error'>" . wfMsg('sf_adddata_badurl') . '</p>');
 81+ $wgOut->addWikiText( "<p class='error'>" . wfMsg('sf_formedit_badurl') . '</p>');
8282 return;
8383 }
8484 }
@@ -87,9 +87,9 @@
8888 if ($target_name != '') {
8989 $target_title = Title::newFromText($target_name);
9090 if ($target_title->exists()) {
91 - $s = wfMsg('sf_editdata_title', $form_title->getText(), $target_title->getPrefixedText());
 91+ $s = wfMsg('sf_formedit_edittitle', $form_title->getText(), $target_title->getPrefixedText());
9292 } else {
93 - $s = wfMsg('sf_adddata_title', $form_title->getText(), $target_title->getPrefixedText());
 93+ $s = wfMsg('sf_formedit_createtitle', $form_title->getText(), $target_title->getPrefixedText());
9494 }
9595 $wgOut->setPageTitle($s);
9696 }
@@ -114,17 +114,17 @@
115115
116116 if (! $form_title || ! $form_title->exists()) {
117117 if ($form_name == '')
118 - $text = '<p class="error">' . wfMsg('sf_adddata_badurl') . "</p>\n";
 118+ $text = '<p class="error">' . wfMsg('sf_formedit_badurl') . "</p>\n";
119119 else {
120120 if (count($alt_forms) > 0) {
121 - $text .= '<div class="infoMessage">' . wfMsg('sf_adddata_altformsonly') . ' ';
 121+ $text .= '<div class="infoMessage">' . wfMsg('sf_formedit_altformsonly') . ' ';
122122 $text .= self::printAltFormsList($alt_forms, $form_name);
123123 $text .= "</div>\n";
124124 } else
125125 $text = '<p class="error">' . wfMsg('sf_formstart_badform', SFUtils::linkText(SF_NS_FORM, $form_name)) . ".</p>\n";
126126 }
127127 } elseif ($target_name == '' && $page_name_formula == '') {
128 - $text = '<p class="error">' . wfMsg('sf_adddata_badurl') . "</p>\n";
 128+ $text = '<p class="error">' . wfMsg('sf_formedit_badurl') . "</p>\n";
129129 } else {
130130 $form_article = new Article($form_title);
131131 $form_definition = $form_article->getContent();
@@ -218,7 +218,7 @@
219219 }
220220 $text = "";
221221 if (count($alt_forms) > 0) {
222 - $text .= '<div class="infoMessage">' . wfMsg('sf_adddata_altforms') . ' ';
 222+ $text .= '<div class="infoMessage">' . wfMsg('sf_formedit_altforms') . ' ';
223223 $text .= self::printAltFormsList($alt_forms, $target_name);
224224 $text .= "</div>\n";
225225 }
Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -318,7 +318,7 @@
319319 $str .= ' <input type="hidden" name="' . $key . '" value="' . $val . '">' . "\n";
320320 }
321321 wfLoadExtensionMessages('SemanticForms');
322 - $button_str = ($inButtonStr != '') ? $inButtonStr : wfMsg('addoreditdata');
 322+ $button_str = ($inButtonStr != '') ? $inButtonStr : wfMsg('createoredit');
323323 if (empty($inAutocompletionSource)) {
324324 $str .= <<<END
325325 <input type="submit" value="$button_str"></p>
Index: trunk/extensions/SemanticForms/includes/SF_FormEditPage.php
@@ -28,7 +28,7 @@
2929 parent::setHeaders();
3030 global $wgOut, $wgTitle;
3131 if( !$this->isConflict ) {
32 - $wgOut->setPageTitle( wfMsg( 'sf_editdata_title',
 32+ $wgOut->setPageTitle( wfMsg( 'sf_formedit_title',
3333 $this->form->getText(), $wgTitle->getPrefixedText() ) );
3434 }
3535 }
Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.inc
@@ -244,7 +244,7 @@
245245 }
246246
247247 static function instancesJavascript($using_choosers) {
248 - $remove_text = wfMsg('sf_editdata_remove');
 248+ $remove_text = wfMsg('sf_formedit_remove');
249249 $javascript_text =<<<END
250250
251251 var num_elements = 0;
Index: trunk/extensions/SemanticForms/includes/SF_FormInputs.inc
@@ -681,7 +681,7 @@
682682 $text .= ' checked="checked"';
683683 $check_set = true;
684684 }
685 - $text .= " $disabled_text $javascript_text/> " . wfMsg('sf_editdata_none') . "\n";
 685+ $text .= " $disabled_text $javascript_text/> " . wfMsg('sf_formedit_none') . "\n";
686686 }
687687
688688 if (($possible_values = $other_args['possible_values']) == null)
@@ -801,7 +801,7 @@
802802 $check_set = true;
803803 }
804804 $disabled_text = ($is_disabled) ? "disabled" : "";
805 - $text .= " $disabled_text/> <em>" . wfMsg('sf_editdata_none') . "</em>\n";
 805+ $text .= " $disabled_text/> <em>" . wfMsg('sf_formedit_none') . "</em>\n";
806806 }
807807
808808 global $wgCategoryTreeMaxDepth;
Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc
@@ -1113,7 +1113,7 @@
11141114 // in the form, to differentiate the inputs the form starts out
11151115 // with from any inputs added by the Javascript
11161116 $section = str_replace('[num]', "[{$instance_num}a]", $section);
1117 - $remove_text = wfMsg('sf_editdata_remove');
 1117+ $remove_text = wfMsg('sf_formedit_remove');
11181118 $form_text .=<<<END
11191119 <div id="wrapper_$sfgFieldNum" class="multipleTemplate">
11201120 $section
@@ -1136,7 +1136,7 @@
11371137 <div id="main_$query_template_name"></div>
11381138
11391139 END;
1140 - $add_another = wfMsg('sf_editdata_addanother');
 1140+ $add_another = wfMsg('sf_formedit_addanother');
11411141 $form_text .=<<<END
11421142 <p style="margin-left:10px;">
11431143 <p><input type="button" onclick="addInstance('starter_$query_template_name', 'main_$query_template_name', '$sfgFieldNum');" value="$add_another" tabindex="$sfgTabIndex" class="addAnother" /></p>
@@ -1215,7 +1215,7 @@
12161216 // add a warning in, if we're editing an existing page and that page
12171217 // appears to not have been created with this form
12181218 if ($this->mPageTitle->exists() && ($existing_page_content != '') && ! $source_page_matches_this_form) {
1219 - $form_text = ' <div class="warningMessage">' . wfMsg('sf_editdata_formwarning', $this->mPageTitle->getFullURL()) . "</div>\n" . $form_text;
 1219+ $form_text = ' <div class="warningMessage">' . wfMsg('sf_formedit_formwarning', $this->mPageTitle->getFullURL()) . "</div>\n" . $form_text;
12201220 }
12211221
12221222 //Substitute the choosers in here too.
@@ -1291,7 +1291,7 @@
12921292 }
12931293 $chooser_text .= "</select>\n";
12941294 }
1295 - $chooser_text .= "<input type='button' onclick=\"addInstanceFromChooser('chooserselect$chooser_count');\" value='" . wfMsg('sf_editdata_addanother') . "' disabled='true' id='chooserbutton$chooser_count'></p>";
 1295+ $chooser_text .= "<input type='button' onclick=\"addInstanceFromChooser('chooserselect$chooser_count');\" value='" . wfMsg('sf_formedit_addanother') . "' disabled='true' id='chooserbutton$chooser_count'></p>";
12961296 }
12971297
12981298 $form_text = str_replace('{{{choosers}}}', $chooser_text, $form_text);
Index: trunk/extensions/SemanticForms/includes/SF_FormEditTab.php
@@ -132,7 +132,7 @@
133133 }
134134 if (count($form_names) > 1) {
135135 wfLoadExtensionMessages('SemanticForms');
136 - $warning_text = ' <div class="warningMessage">' . wfMsg('sf_editdata_morethanoneform') . "</div>\n";
 136+ $warning_text = ' <div class="warningMessage">' . wfMsg('sf_formedit_morethanoneform') . "</div>\n";
137137 global $wgOut;
138138 $wgOut->addHTML($warning_text);
139139 }

Status & tagging log