r63480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63479‎ | r63480 | r63481 >
Date:18:22, 9 March 2010
Author:yaron
Status:deferred
Tags:
Comment:
Replaced hardcoded function name with __METHOD__
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_AutocompleteAPI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_AutocompleteAPI.php
@@ -117,7 +117,6 @@
118118 public static function getAllValuesForProperty($is_relation, $property_name, $substring = null) {
119119 global $sfgMaxAutocompleteValues;
120120
121 - $fname = "SFAutocompleteAPI::getAllValuesForProperty";
122121 $values = array();
123122 $db = wfGetDB( DB_SLAVE );
124123 $sql_options = array();
@@ -138,9 +137,8 @@
139138 $conditions .= " AND (REPLACE(LOWER(CONVERT($value_field USING utf8)),'_',' ') LIKE '" . $substring . "%' OR REPLACE(LOWER(CONVERT($value_field USING utf8)),'_',' ') LIKE '% " . $substring . "%')";
140139 }
141140 $sql_options['ORDER BY'] = $value_field;
142 - $res = $db->select( $from_clause,
143 - "DISTINCT $value_field",
144 - $conditions, $fname, $sql_options);
 141+ $res = $db->select($from_clause, "DISTINCT $value_field",
 142+ $conditions, __METHOD__, $sql_options);
145143 while ($row = $db->fetchRow($res)) {
146144 if ($substring != null) {
147145 $values[] = array('title' => str_replace('_', ' ', $row[0]));

Status & tagging log