r63441 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63440‎ | r63441 | r63442 >
Date:23:11, 8 March 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r63411 and small typo fix in sql file
Modified paths:
  • /trunk/extensions/Storyboard/storyboard.sql (modified) (history)
  • /trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/storyboard.sql
@@ -7,7 +7,7 @@
88 story_author_location VARCHAR(255) NOT NULL,
99 story_author_occupation VARCHAR(255) NOT NULL,
1010 story_author_image VARCHAR(255) NULL, -- TODO: find out if this is an acceptible way to refer to an image
11 - story_hit_count INT(8) unsigned NOT NULL, default '0',
 11+ story_hit_count INT(8) unsigned NOT NULL default '0',
1212 story_title VARCHAR(255) NOT NULL,
1313 story_text MEDIUMBLOB NOT NULL,
1414 story_modified CHAR(14) binary NOT NULL default '',
Index: trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
@@ -61,7 +61,7 @@
6262
6363 $defaultName = '';
6464 if ( $wgUser->isLoggedIn() ) {
65 - $defaultName = strlen($wgUser->getRealName()) > 0 ? $wgUser->getRealName() : $wgUser->getName();
 65+ $defaultName = $wgUser->getRealName() !== '' ? $wgUser->getRealName() : $wgUser->getName();
6666 }
6767 $formBody .= '<tr>' .
6868 Html::element( 'td', array('width' => '100%'), wfMsg( 'storyboard-yourname' ) ) .
@@ -152,8 +152,8 @@
153153 'story_author_occupation' => $wgRequest->getText( 'occupation' ),
154154 'story_title' => $wgRequest->getText( 'storytitle' ),
155155 'story_text' => $wgRequest->getText( 'storytext' ),
156 - 'story_created' => $dbw->timestamp(),
157 - 'story_modified' => $dbw->timestamp(),
 156+ 'story_created' => $dbw->timestamp( time() ),
 157+ 'story_modified' => $dbw->timestamp( time() ),
158158 );
159159
160160 // If the user is logged in, also store his user id.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63411Added default name for logged in users and 3 more fields to store in the db.jeroendedauw20:12, 8 March 2010

Status & tagging log