r63362 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63361‎ | r63362 | r63363 >
Date:16:53, 7 March 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Partial follow up to r63355
Modified paths:
  • /trunk/extensions/Storyboard/Storyboard.i18n.php (modified) (history)
  • /trunk/extensions/Storyboard/tags/Storysubmission/storysubmission.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/Storyboard.i18n.php
@@ -36,7 +36,7 @@
3737 'storyboard-contact' => 'Your E-mail address or telephone number',
3838 'storyboard-agreement' => 'I agree with the publication of this story.',
3939 'storyboard-charsleft' => '($1 {{PLURAL:$1|character|characters}} left)',
40 - 'storyboard-cannotbelonger' => 'Your story may not exceed $ characters!',
 40+ 'storyboard-cannotbelonger' => 'Your story is <b>$1</b> {{PLURAL:$1|character|characters}} to long!',
4141 'storyboard-charsneeded' => '($1 more {{PLURAL:$1|character|characters}} needed)',
4242 'storyboard-needtoagree' => 'You need to agree to the publication of your story to submit it.'
4343 );
Index: trunk/extensions/Storyboard/tags/Storysubmission/storysubmission.js
@@ -17,8 +17,7 @@
1818
1919 if(textlength > upperLimit) {
2020 info.innerHTML = 'Your story may not exceed ' + upperLimit + ' characters!'; // TODO: i18n
21 - textarea.value = text.substr( 0, upperLimit );
22 - return true;
 21+ return false;
2322 } else if (textlength < lowerLimit) {
2423 info.innerHTML = '('+ ( lowerLimit - textlength ) + ' more characters needed)'; // TODO: i18n
2524 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63355Added new fields to the storysubmission form and restructured the old ones so...jeroendedauw02:36, 7 March 2010

Status & tagging log