r63229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63228‎ | r63229 | r63230 >
Date:22:15, 3 March 2010
Author:platonides
Status:ok
Tags:
Comment:
Remove unused VectorTemplateToolboxEnd hook.
Per-skin hooks are evil. Extensions should use SkinTemplateToolboxEnd.
Modified paths:
  • /branches/REL1_16/phase3/docs/hooks.txt (modified) (history)
  • /branches/REL1_16/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -611,7 +611,6 @@
612612 <?php elseif ( $this->data['nav_urls']['permalink']['href'] === '' ): ?>
613613 <li id="t-ispermalink"<?php echo $this->skin->tooltip( 't-ispermalink' ) ?>><?php $this->msg( 'permalink' ) ?></li>
614614 <?php endif; ?>
615 - <?php wfRunHooks( 'VectorTemplateToolboxEnd', array( &$this ) ); ?>
616615 <?php wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this ) ); ?>
617616 </ul>
618617 </div>
Index: trunk/phase3/docs/hooks.txt
@@ -1765,13 +1765,6 @@
17661766 new toggles
17671767 $toggles: array of toggles to add
17681768
1769 -'VectorTemplateToolboxEnd': Called by Vector skin after toolbox links have
1770 -been rendered (useful for adding more)
1771 -Note: this is only run for the Vector skin. To add items to the toolbox
1772 -for all 'SkinTemplate'-type skins, use the SkinTemplateToolboxEnd hook
1773 -instead.
1774 -$tools: array of tools
1775 -
17761769 'WantedPages::getSQL': called in WantedPagesPage::getSQL(), can be used to
17771770 alter the SQL query which gets the list of wanted pages
17781771 &$wantedPages: WantedPagesPage object
Index: branches/REL1_16/phase3/skins/Vector.php
@@ -611,7 +611,6 @@
612612 <?php elseif ( $this->data['nav_urls']['permalink']['href'] === '' ): ?>
613613 <li id="t-ispermalink"<?php echo $this->skin->tooltip( 't-ispermalink' ) ?>><?php $this->msg( 'permalink' ) ?></li>
614614 <?php endif; ?>
615 - <?php wfRunHooks( 'VectorTemplateToolboxEnd', array( &$this ) ); ?>
616615 <?php wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this ) ); ?>
617616 </ul>
618617 </div>
Index: branches/REL1_16/phase3/docs/hooks.txt
@@ -1765,13 +1765,6 @@
17661766 new toggles
17671767 $toggles: array of toggles to add
17681768
1769 -'VectorTemplateToolboxEnd': Called by Vector skin after toolbox links have
1770 -been rendered (useful for adding more)
1771 -Note: this is only run for the Vector skin. To add items to the toolbox
1772 -for all 'SkinTemplate'-type skins, use the SkinTemplateToolboxEnd hook
1773 -instead.
1774 -$tools: array of tools
1775 -
17761769 'WantedPages::getSQL': called in WantedPagesPage::getSQL(), can be used to
17771770 alter the SQL query which gets the list of wanted pages
17781771 &$wantedPages: WantedPagesPage object

Status & tagging log