r63215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63214‎ | r63215 | r63216 >
Date:18:28, 3 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
MFT r60736
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -855,11 +855,14 @@
856856 * Get a <select> for selecting languages
857857 */
858858 function getLanguageSelector( $name, $label, $selectedCode ) {
 859+ global $wgDummyLanguageCodes;
859860 $s = Xml::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
860861
861862 $languages = Language::getLanguageNames();
862863 ksort( $languages );
 864+ $dummies = array_flip( $wgDummyLanguageCodes );
863865 foreach ( $languages as $code => $name ) {
 866+ if ( isset( $dummies[$code] ) ) continue;
864867 $s .= "\n" . Xml::option( "$code - $name", $code, $code == $selectedCode );
865868 }
866869 $s .= "\n</select>\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60736Clean-up for r60598: introduced a global setting for non-existant languages....maxsem16:55, 6 January 2010

Status & tagging log