r63211 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63210‎ | r63211 | r63212 >
Date:18:05, 3 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
Fixed r63117, updated comments
Modified paths:
  • /branches/new-installer/phase3/includes/db/SchemaBuilder.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/db/SchemaBuilder.php
@@ -411,7 +411,7 @@
412412 ),
413413 )
414414 );
415 - $this->tablesToDelete[] = array_merge( $this->tablesToDelete,
 415+ $this->tablesToDelete = array_merge( $this->tablesToDelete,
416416 array( 'searchindex_content', 'searchindex_segdir', 'searchindex_segments' )
417417 );
418418 }
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -72,10 +72,10 @@
7373 );
7474
7575 /**
76 - * Known database types. These correspond to the class names <type>_Installer,
 76+ * Known database types. These correspond to the class names <type>Installer,
7777 * and are also MediaWiki database types valid for $wgDBtype.
7878 *
79 - * To add a new type, create a <type>_Installer class and a Database<type>
 79+ * To add a new type, create a <type>Installer class and a Database<type>
8080 * class, and add a config-type-<type> message to MessagesEn.php.
8181 * @private
8282 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63117Unfortunately, being absolutely abstract is impossible, so extensions will ne...maxsem12:36, 1 March 2010

Status & tagging log