r63140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63139‎ | r63140 | r63141 >
Date:22:27, 1 March 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.5.4
Modified paths:
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_BasePointMap.php (modified) (history)
  • /trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_DisplayPoint.php (modified) (history)
  • /trunk/extensions/Maps/ParserFunctions/Maps_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_DisplayPoint.php
@@ -26,7 +26,7 @@
2727 */
2828 function efMapsDisplayPointMagic( &$magicWords, $langCode ) {
2929 // The display_address(es) aliases are for backward compatibility only, and will be removed eventually.
30 - $magicWords['display_point'] = array( 0, 'display_point', 'display_points', 'display_address', 'display_addresses' );
 30+ $magicWords['display_point'] = array( 0, 'display_point', 'display_points' );
3131
3232 return true; // Unless we return true, other parser functions won't get loaded.
3333 }
Index: trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_BasePointMap.php
@@ -15,8 +15,8 @@
1616
1717 /**
1818 * Abstract class MapsBasePointMap provides the scafolding for classes handling display_point(s)
19 - * and display_address(es) calls for a spesific mapping service. It inherits from MapsMapFeature and therefore
20 - * forces inheriting classes to implement sereveral methods.
 19+ * calls for a spesific mapping service. It inherits from MapsMapFeature and therefore forces
 20+ * inheriting classes to implement sereveral methods.
2121 *
2222 * @ingroup Maps
2323 *
Index: trunk/extensions/Maps/ParserFunctions/Maps_ParserFunctions.php
@@ -42,7 +42,7 @@
4343
4444 // Go through the parser functions supported by the mapping service, and load their classes.
4545 foreach($serviceData['pf'] as $parser_name => $parser_data) {
46 - $file = $parser_data['local'] ? $egMapsDir . $parser_data['file'] : $IP . '/extensions/' . $parser_data['file'];
 46+ $file = array_key_exists('local', $parser_data) && $parser_data['local'] ? $egMapsDir . $parser_data['file'] : $IP . '/extensions/' . $parser_data['file'];
4747 $wgAutoloadClasses[$parser_data['class']] = $file;
4848 }
4949 }
@@ -159,7 +159,7 @@
160160 *
161161 * @return array
162162 */
163 - private static function filterInvalidCoords(&$coordList, $delimeter = ';') {
 163+ public static function filterInvalidCoords(&$coordList, $delimeter = ';') {
164164 $coordFails = array();
165165 $validCoordinates = array();
166166 $coordinates = explode($delimeter, $coordList);
@@ -257,7 +257,7 @@
258258 *
259259 * @return class
260260 */
261 - private static function getParserClassInstance($service, $parserFunction) {
 261+ public static function getParserClassInstance($service, $parserFunction) {
262262 global $egMapsServices;
263263 return new $egMapsServices[$service]['pf'][$parserFunction]['class']();
264264 }
@@ -273,7 +273,7 @@
274274 *
275275 * @return boolean
276276 */
277 - private static function inParamAliases($name, $mainParamName, array $paramInfo = array(), $compareMainName = true) {
 277+ public static function inParamAliases($name, $mainParamName, array $paramInfo = array(), $compareMainName = true) {
278278 $equals = $compareMainName && $mainParamName == $name;
279279
280280 if (array_key_exists($mainParamName, $paramInfo)) {
Index: trunk/extensions/Maps/Maps.php
@@ -33,7 +33,7 @@
3434 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3535 }
3636 else {
37 - define('Maps_VERSION', '0.5.4 rc1');
 37+ define('Maps_VERSION', '0.5.4');
3838
3939 $egMapsScriptPath = (isset($wgExtensionAssetsPath) && $wgExtensionAssetsPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions') . '/Maps';
4040 $egMapsDir = dirname( __FILE__ ) . '/';

Status & tagging log