r63131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63130‎ | r63131 | r63132 >
Date:20:10, 1 March 2010
Author:nad
Status:deferred
Tags:
Comment:
call examineBraces statically
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -267,7 +267,7 @@
268268 $watch = $wgRequest->getText( 'wpWatchthis' );
269269
270270 # Get the location and length of the record braces to replace
271 - foreach ( $this->examineBraces( $text ) as $brace ) if ( $brace['NAME'] == $type ) $braces = $brace;
 271+ foreach ( self::examineBraces( $text ) as $brace ) if ( $brace['NAME'] == $type ) $braces = $brace;
272272
273273 # Attempt to save the article if allowed
274274 if ( !$wgSecurityProtectRecords || $this->template->userCan( 'edit' ) ) {
@@ -291,7 +291,7 @@
292292
293293 # Extract current values from article
294294 $braces = false;
295 - foreach ( $this->examineBraces( $text ) as $brace ) if ( $brace['NAME'] == $type ) $braces = $brace;
 295+ foreach ( self::examineBraces( $text ) as $brace ) if ( $brace['NAME'] == $type ) $braces = $brace;
296296 if ( $braces ) {
297297
298298 # Fill in current values
@@ -733,7 +733,7 @@
734734 $max = 25;
735735 do {
736736 $braces = false;
737 - foreach ( $this->examineBraces( $this->form ) as $brace ) {
 737+ foreach ( self::examineBraces( $this->form ) as $brace ) {
738738 if ( $brace['DEPTH'] == 2 ) $braces = $brace;
739739 }
740740 if ( $braces ) {

Status & tagging log