r62994 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62993‎ | r62994 | r62995 >
Date:02:41, 26 February 2010
Author:mah
Status:ok
Tags:
Comment:
follow-up r61836 - allow any URL
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -186,7 +186,7 @@
187187 */
188188 public function addScriptFile( $file ) {
189189 global $wgStylePath, $wgStyleVersion;
190 - if( substr( $file, 0, 1 ) == '/' || substr( $file, 0, 7 ) == 'http://' ) {
 190+ if( substr( $file, 0, 1 ) == '/' || preg_match( '#^[a-z]*://#i', $file ) ) {
191191 $path = $file;
192192 } else {
193193 $path = "{$wgStylePath}/common/{$file}";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61836Allow external URLs (e.g. http://bits.wikimedia.org/foo) in OutputPage::addSc...catrope00:44, 2 February 2010

Status & tagging log