r62978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62977‎ | r62978 | r62979 >
Date:22:54, 25 February 2010
Author:nad
Status:deferred
Tags:
Comment:
add id attributes to title and type inputs in update/create form
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -238,11 +238,11 @@
239239 $wgOut->addWikiText( "==" . wfMsg( 'recordadmin-create', $type ) . "==\n" );
240240 $wgOut->addHTML(
241241 '<table class="recordadmin-create">'
242 - . '<tr><td class="recordadmin-create-id"><b>' . wfMsg( 'recordadmin-recordid' ) . '</b>&nbsp;' . Xml::element( 'input', array( 'name' => 'wpTitle', 'size' => 30, 'value' => $wpTitle ) )
 242+ . '<tr><td class="recordadmin-create-id"><b>' . wfMsg( 'recordadmin-recordid' ) . '</b>&nbsp;' . Xml::element( 'input', array( id => 'ra-title', 'name' => 'wpTitle', 'size' => 30, 'value' => $wpTitle ) )
243243 . '&nbsp;&nbsp;&nbsp;' . Xml::element( 'input', array( 'name' => 'wpInvert', 'type' => 'checkbox' ) ) . ' ' . wfMsg( 'recordadmin-invert' )
244244 . '</td></tr>'
245245 . '<tr><td>' . $this->form . '</td></tr>'
246 - . '<tr><td>' . Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'wpType', 'value' => $type ) ) . '</td></tr>'
 246+ . '<tr><td>' . Xml::element( 'input', array( 'type' => 'hidden', 'id' => 'ra-type', 'name' => 'wpType', 'value' => $type ) ) . '</td></tr>'
247247 . '<tr><td>'
248248 . Xml::element( 'input', array( 'type' => 'submit', 'name' => 'wpFind', 'id' => 'ra-find', 'value' => wfMsg( 'recordadmin-buttonsearch' ) ) )
249249 . Xml::element( 'input', array( 'type' => 'submit', 'name' => 'wpCreate', 'id' => 'ra-create', 'value' => wfMsg( 'recordadmin-buttoncreate' ) ) )
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -11,7 +11,7 @@
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
1414
15 -define( 'RECORDADMIN_VERSION', '0.11.0, 2010-02-18' );
 15+define( 'RECORDADMIN_VERSION', '0.11.1, 2010-02-26' );
1616
1717 $wgRecordAdminUseNamespaces = false; # Whether record articles should be in a namespace of the same name as their type
1818 $wgRecordAdminCategory = 'Records'; # Category containing record types

Status & tagging log