r62961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62960‎ | r62961 | r62962 >
Date:16:05, 25 February 2010
Author:catrope
Status:ok
Tags:
Comment:
DynamicSidebar: Kill $wgDynamicSidebarDebug per CR on r62947
Modified paths:
  • /trunk/extensions/DynamicSidebar/DynamicSidebar.body.php (modified) (history)
  • /trunk/extensions/DynamicSidebar/DynamicSidebar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DynamicSidebar/DynamicSidebar.body.php
@@ -150,15 +150,11 @@
151151 * @access private
152152 */
153153 private static function printDebug( $debugText, $debugArr = null ) {
154 - global $wgDynamicSidebarDebug;
155 -
156 - if ( $wgDynamicSidebarDebug ) {
157 - if ( isset( $debugArr ) ) {
158 - $text = $debugText . " " . implode( "::", $debugArr );
159 - wfDebugLog( 'dynamic-sidebar', $text, false );
160 - } else {
161 - wfDebugLog( 'dynamic-sidebar', $debugText, false );
162 - }
 154+ if ( isset( $debugArr ) ) {
 155+ $text = $debugText . " " . implode( "::", $debugArr );
 156+ wfDebugLog( 'dynamic-sidebar', $text, false );
 157+ } else {
 158+ wfDebugLog( 'dynamic-sidebar', $debugText, false );
163159 }
164160 }
165161 }
Index: trunk/extensions/DynamicSidebar/DynamicSidebar.php
@@ -25,7 +25,6 @@
2626 }
2727
2828 // Set defaults
29 -$wgDynamicSidebarDebug = false;
3029 $wgDynamicSidebarUseUserpages = true;
3130 $wgDynamicSidebarUseGroups = true;
3231 $wgDynamicSidebarUseCategories = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62947Initial commit of DynamicSidebar; see documentation at:...laner02:44, 25 February 2010

Status & tagging log