r62944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62943‎ | r62944 | r62945 >
Date:02:26, 25 February 2010
Author:dale
Status:deferred
Tags:
Comment:
* stub to close fullscreen on player select
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js
@@ -995,6 +995,8 @@
996996 mw.log('getPlayerSelect');
997997
998998 var embedPlayer = this.embedPlayer;
 999+
 1000+ var _this = this;
9991001
10001002 $playerSelect = $j('<div />')
10011003 .append(
@@ -1026,8 +1028,7 @@
10271029 .text(
10281030 supporting_players[i].getName()
10291031 )
1030 - .addClass( 'ui-state-highlight ui-corner-all' );
1031 -
 1032+ .addClass( 'ui-state-highlight ui-corner-all' );
10321033 } else {
10331034 // Non active player add link to select:
10341035 $playerLine = $j( '<a />')
@@ -1045,6 +1046,12 @@
10461047 mw.log( 'source id: ' + source_id + ' player id: ' + default_player_id );
10471048
10481049 embedPlayer.ctrlBuilder.closeMenuOverlay();
 1050+
 1051+ // Close fullscreen if we are in fullscreen mode
 1052+ if( _this.fullscreenMode ){
 1053+ _this.restoreWindowPlayer()
 1054+ }
 1055+
10491056 embedPlayer.mediaElement.selectSource( source_id );
10501057
10511058 mw.EmbedTypes.players.setPlayerPreference(
@@ -1444,7 +1451,7 @@
14451452 .css({
14461453 "position" : 'absolute',
14471454 "left" : '33px',
1448 - "right" : ( (embedPlayer.getPlayerWidth() - ctrlObj.available_width) - 33) + 'px'
 1455+ "right" : ( ( embedPlayer.getPlayerWidth() - ctrlObj.available_width ) - 33) + 'px'
14491456 })
14501457 // Playhead binding
14511458 .slider( {

Status & tagging log