r62868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62867‎ | r62868 | r62869 >
Date:10:04, 23 February 2010
Author:dale
Status:deferred
Tags:
Comment:
* fixed ogg warning check
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/kplayerEmbed.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/mw.EmbedPlayer.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/skins/ctrlBuilder.js
@@ -232,7 +232,7 @@
233233 // See if we have native support for ogg:
234234 var supporting_players = mw.EmbedTypes.players.getMIMETypePlayers( 'video/ogg' );
235235 for ( var i = 0; i < supporting_players.length; i++ ) {
236 - if ( supporting_players[i].id == 'videoElement' ) {
 236+ if ( supporting_players[i].id == 'oggNative' ) {
237237 return false;
238238 }
239239 }
@@ -248,8 +248,9 @@
249249 }
250250 }
251251 // No ogg src... no point in download firefox link
252 - if ( !foundOgg )
 252+ if ( !foundOgg ){
253253 return false;
 254+ }
254255 }
255256 return true;
256257 },
Index: branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/kplayerEmbed.js
@@ -8,13 +8,13 @@
99
1010 // List of supported features:
1111 supports: {
12 - 'playHead':true,
13 - 'pause':true,
14 - 'stop':true,
15 - 'timeDisplay':true,
16 - 'volumeControl':true,
17 - 'overlay':false,
18 - 'fullscreen':false
 12+ 'playHead' : true,
 13+ 'pause' : true,
 14+ 'stop' : true,
 15+ 'timeDisplay' : true,
 16+ 'volumeControl' : true,
 17+ 'overlay' : true,
 18+ 'fullscreen' : false
1919 },
2020
2121 /*
Index: branches/js2-work/phase3/js/mwEmbed/modules/EmbedPlayer/mw.EmbedPlayer.js
@@ -1752,10 +1752,11 @@
17531753 // Call the ctrlBuilder end event::
17541754
17551755 //if kalturaAttribution and k-skin show the "credits" screen:
1756 - if( this.ctrlBuilder.showCredits ) {
 1756+ if( mw.getConfig( 'kalturaAttribution' ) && this.ctrlBuilder.showCredits ) {
17571757 this.ctrlBuilder.showCredits();
17581758 return ;
17591759 }
 1760+
17601761 // Related videos:
17611762 $j( '#img_thumb_' + this.id ).css( 'zindex', 1 );
17621763 this.$interface.find( '.play-btn-large' ).hide();
@@ -2959,7 +2960,7 @@
29602961 default_players : { },
29612962
29622963 /**
2963 - * Initializartion function defiens the default order for players for
 2964+ * Initializartion function sets the default order for players for
29642965 * a given mime type
29652966 */
29662967 init : function() {
@@ -2978,10 +2979,9 @@
29792980 this.default_players['text/html'] = ['html'];
29802981 this.default_players['image/jpeg'] = ['html'];
29812982 this.default_players['image/png'] = ['html'];
2982 - this.default_players['image/svg'] = ['html'];
 2983+ this.default_players['image/svg'] = ['html'];
29832984
29842985
2985 -
29862986 },
29872987
29882988 /**

Status & tagging log