r62841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62840‎ | r62841 | r62842 >
Date:21:21, 22 February 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
<<<END -> <<<EOT
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispMap.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispPoint.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispPoint.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispPoint.php
@@ -61,7 +61,7 @@
6262 global $wgJsMimeType;
6363
6464 // TODO
65 - $this->output .=<<<END
 65+ $this->output .=<<<EOT
6666 <div id="$this->mapName" style="width:{$this->width}px; height:{$this->height}px"></div>
6767 <script type="$wgJsMimeType"> /*<![CDATA[*/
6868 addOnloadHook(
@@ -76,7 +76,7 @@
7777 )
7878 );
7979 /*]]>*/ </script>
80 -END;
 80+EOT;
8181
8282 }
8383
Index: trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispMap.php
@@ -58,7 +58,7 @@
5959 public function addSpecificMapHTML() {
6060 global $wgJsMimeType;
6161
62 - $this->output .=<<<END
 62+ $this->output .=<<<EOT
6363 <div id="$this->mapName" style="width:{$this->width}px; height:{$this->height}px"></div>
6464 <script type="$wgJsMimeType"> /*<![CDATA[*/
6565 addOnloadHook(
@@ -73,7 +73,7 @@
7474 )
7575 );
7676 /*]]>*/ </script>
77 -END;
 77+EOT;
7878
7979 }
8080
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php
@@ -67,8 +67,7 @@
6868
6969 $onloadFunctions = MapsGoogleMaps::addOverlayOutput($this->output, $this->mapName, $this->overlays, $this->controls);
7070
71 - $this->output .=<<<END
72 -
 71+ $this->output .=<<<EOT
7372 <div id="$this->mapName"></div>
7473 <script type="$wgJsMimeType"> /*<![CDATA[*/
7574 addOnloadHook(
@@ -86,9 +85,8 @@
8786 }, [])
8887 );
8988 /*]]>*/ </script>
 89+EOT;
9090
91 -END;
92 -
9391 $this->output .= $onloadFunctions;
9492
9593 }
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php
@@ -270,12 +270,12 @@
271271 }
272272 }
273273
274 - $output .=<<<END
 274+ $output .=<<<EOT
275275 <script type='$wgJsMimeType'>var timer_$mapName;</script>
276276 <div class='outer-more' id='$mapName-outer-more'><form action=''><div class='more-box' id='$mapName-more-box'>
277277 $overlayHtml
278278 </div></form></div>
279 -END;
 279+EOT;
280280
281281 return $onloadFunctions;
282282 }
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php
@@ -69,8 +69,7 @@
7070
7171 $onloadFunctions = MapsGoogleMaps::addOverlayOutput($this->output, $this->mapName, $this->overlays, $this->controls);
7272
73 - $this->output .=<<<END
74 -
 73+ $this->output .=<<<EOT
7574 <div id="$this->mapName"></div>
7675 <script type="$wgJsMimeType"> /*<![CDATA[*/
7776 addOnloadHook(
@@ -90,9 +89,8 @@
9190 )
9291 );
9392 /*]]>*/ </script>
 93+EOT;
9494
95 -END;
96 -
9795 $this->output .= $onloadFunctions;
9896
9997 }
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispPoint.php
@@ -55,7 +55,7 @@
5656 public function addSpecificMapHTML() {
5757 global $wgJsMimeType;
5858
59 - $this->output .= <<<END
 59+ $this->output .= <<<EOT
6060 <div id="$this->mapName" style="width: {$this->width}px; height: {$this->height}px;"></div>
6161
6262 <script type="$wgJsMimeType">/*<![CDATA[*/
@@ -63,7 +63,7 @@
6464 initializeYahooMap('$this->mapName', $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$this->types], [$this->controls], $this->autozoom, [$this->markerString], $this->height)
6565 );
6666 /*]]>*/</script>
67 -END;
 67+EOT;
6868 }
6969
7070 }
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispMap.php
@@ -48,7 +48,7 @@
4949 public function addSpecificMapHTML() {
5050 global $wgJsMimeType;
5151
52 - $this->output .= <<<END
 52+ $this->output .= <<<EOT
5353 <div id="$this->mapName" style="width: {$this->width}px; height: {$this->height}px;"></div>
5454
5555 <script type="$wgJsMimeType">/*<![CDATA[*/
@@ -56,7 +56,7 @@
5757 initializeYahooMap('$this->mapName', $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$this->types], [$this->controls], $this->autozoom, [], $this->height)
5858 );
5959 /*]]>*/</script>
60 -END;
 60+EOT;
6161 }
6262
6363 }

Status & tagging log