r62833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62832‎ | r62833 | r62834 >
Date:19:28, 22 February 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.5.4
* Small security fixes
* Use of $wgExtensionAssetsPath
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.php
@@ -33,10 +33,9 @@
3434 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3535 }
3636 else {
37 - define('Maps_VERSION', '0.5.4 a3');
 37+ define('Maps_VERSION', '0.5.4 a4');
3838
39 - // TODO: try to get out the hardcoded path.
40 - $egMapsScriptPath = $wgScriptPath . '/extensions/Maps';
 39+ $egMapsScriptPath = (isset($wgExtensionAssetsPath) && $wgExtensionAssetsPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions') . '/Maps';
4140 $egMapsDir = dirname( __FILE__ ) . '/';
4241
4342 $egMapsStyleVersion = $wgStyleVersion . '-' . Maps_VERSION;
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php
@@ -69,7 +69,7 @@
7070
7171 $this->output .=<<<END
7272
73 -<div id="$this->mapName" class="$this->class" style="$this->style" ></div>
 73+<div id="$this->mapName"></div>
7474 <script type="$wgJsMimeType"> /*<![CDATA[*/
7575 addOnloadHook(
7676 initializeGoogleMap('$this->mapName',
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php
@@ -89,8 +89,6 @@
9090 'default' => $egMapsGoogleAutozoom,
9191 'output-type' => 'boolstr'
9292 ),
93 - 'class' => array(),
94 - 'style' => array(),
9593 );
9694 }
9795
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php
@@ -71,7 +71,7 @@
7272
7373 $this->output .=<<<END
7474
75 -<div id="$this->mapName" class="$this->class" style="$this->style" ></div>
 75+<div id="$this->mapName"></div>
7676 <script type="$wgJsMimeType"> /*<![CDATA[*/
7777 addOnloadHook(
7878 initializeGoogleMap('$this->mapName',

Status & tagging log