r62795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62794‎ | r62795 | r62796 >
Date:23:59, 21 February 2010
Author:simetrical
Status:ok
Tags:
Comment:
Specify percentage width on Modern search box

As discussed on IRC. This reverts r62794, and is intended to be a
better fix for bug 19194. By removing the display: block, we work
around the WebKit bug <https://bugs.webkit.org/show_bug.cgi?id=27982&gt;.
But then on some font sizes, the text box becomes too narrow, so the
"Go" button winds up on the same line as the search box. thedj reported
this as a problem both with r62794 and with simple removal of display:
block, but said it was fine with width: 85%, which also looks fine to
me.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/modern/main.css
@@ -153,19 +153,11 @@
154154 }
155155
156156 #searchInput {
157 - display: block;
 157+ width: 85%;
158158 margin-left: auto;
159159 margin-right: auto;
160160 }
161161
162 -/** safari and chrome specific hack for search box (bug #19194) **/
163 -@media screen and (-webkit-min-device-pixel-ratio:0) {
164 - #searchInput {
165 - display: inline;
166 - }
167 -}
168 -
169 -
170162 #p-search #searchform div div {
171163 margin-top: .4em;
172164 }
Index: trunk/phase3/RELEASE-NOTES
@@ -760,6 +760,7 @@
761761 * (bug 22540) ForeignApiRepos no longer try to store thumbnails that don't exist
762762 * (bug 22551) Special:Resetpass now has a "Cancel" button that sends the user to
763763 the page set in the &returnto parameter.
 764+* (bug 19194) Search box in Modern skin doesn't focus with Safari/Chrome
764765
765766 == API changes in 1.16 ==
766767

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62794Fixes bug 19194 (search box issue in Safari and Chrome)lhridley23:14, 21 February 2010

Status & tagging log