r62758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62757‎ | r62758 | r62759 >
Date:01:44, 21 February 2010
Author:simetrical
Status:ok
Tags:
Comment:
Fix comment, remove unused global
Modified paths:
  • /trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Html.php
@@ -137,7 +137,7 @@
138138 * tag (and the self-closing / in XML mode for empty elements).
139139 */
140140 public static function openElement( $element, $attribs = array() ) {
141 - global $wgHtml5, $wgWellFormedXml;
 141+ global $wgHtml5;
142142 $attribs = (array)$attribs;
143143 # This is not required in HTML5, but let's do it anyway, for
144144 # consistency and better compression.
@@ -376,8 +376,9 @@
377377 "\t" => '	'
378378 );
379379 if ( $wgWellFormedXml ) {
380 - # '<' must be escaped in attributes for XML for some
381 - # reason, per spec: http://www.w3.org/TR/xml/#NT-AttValue
 380+ # This is allowed per spec: <http://www.w3.org/TR/xml/#NT-AttValue>
 381+ # But reportedly it breaks some XML tools? FIXME: is this
 382+ # really true?
382383 $map['<'] = '&lt;';
383384 }
384385 $ret .= " $key=$quote" . strtr( $value, $map ) . $quote;

Status & tagging log