r62748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62747‎ | r62748 | r62749 >
Date:19:22, 20 February 2010
Author:ialex
Status:ok
Tags:
Comment:
Fix for r62744: use tabs for indentation, not spaces
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -283,9 +283,9 @@
284284
285285 function doQuery( $sql ) {
286286 wfDebug( "SQL: [$sql]\n" );
287 - if ( !mb_check_encoding( $sql ) ) {
288 - throw new MWException( "SQL encoding is invalid\n$sql" );
289 - }
 287+ if ( !mb_check_encoding( $sql ) ) {
 288+ throw new MWException( "SQL encoding is invalid\n$sql" );
 289+ }
290290
291291 // handle some oracle specifics
292292 // remove AS column/table/subquery namings

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62744tableName has to be encoded before field type checkingfreakolowsky18:27, 20 February 2010

Status & tagging log