r62729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62728‎ | r62729 | r62730 >
Date:03:52, 20 February 2010
Author:dale
Status:deferred
Tags:
Comment:
* removed minification conflict non-used code
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/jquery/jquery.ui/ui/ui.slider.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/skins/kskin/kskinConfig.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/jquery/jquery.ui/ui/ui.slider.js
@@ -530,4 +530,3 @@
531531 });
532532
533533 })(jQuery);
534 -
Index: branches/js2-work/phase3/js/mwEmbed/skins/kskin/kskinConfig.js
@@ -66,14 +66,8 @@
6767 'optionsMenu': {
6868 'w' : 0,
6969 'o' : function( ctrlObj ) {
70 - var embedPlayer = ctrlObj.embedPlayer;
 70+ var embedPlayer = ctrlObj.embedPlayer;
7171
72 -
73 - var menuOffset = ( embedPlayer.getPlayerHeight() < ctrlObj.getOverlayHeight() ) ?
74 - 'top:' + + 'px;' : '';
75 -
76 -
77 -
7872 $menuOverlay = $j( '<div />')
7973 .attr('id', 'blackbg_' + embedPlayer.id )
8074 .addClass( 'k-menu ui-widget-content' )
@@ -85,6 +79,7 @@
8680 // Setup menu offset ( if player height < getOverlayHeight )
8781 // This displays the menu outside of the player on small embeds
8882 if ( embedPlayer.getPlayerHeight() < ctrlObj.getOverlayHeight() ) {
 83+
8984 $menuOverlay.css( 'top', parseInt( embedPlayer.getPlayerHeight() + ctrlObj.getControlBarHeight() ) + 'px' );
9085
9186 // Special common overflow hack for thumbnail display of player
@@ -130,7 +125,8 @@
131126 // Add the menuScreens to the menuOverlay
132127 $menuOverlay.append( $menuScreens );
133128
134 - return $menuOverlay;
 129+ return $menuOverlay;
 130+
135131 }
136132 }
137133 },
Index: branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r98';
 8+var mwRemoteVersion = 'r99';
99 var mwUseScriptLoader = true;
1010
1111 // Log the mwRemote version ( will determine what version of js we get )

Status & tagging log