r62724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62723‎ | r62724 | r62725 >
Date:22:11, 19 February 2010
Author:nimishg
Status:ok
Tags:
Comment:
change divs in template editors to spans
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.html (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.templateEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.templateEditor.js
@@ -68,7 +68,8 @@
6969 end: tokenArray[endIndex].offset,
7070 type: 'template',
7171 anchor: 'wrap',
72 - splitPs: model.isCollapsible(),
 72+ //splitPs: model.isCollapsible(),
 73+ splitPs: false,
7374 afterWrap: $.wikiEditor.modules.templateEditor.fn.stylize,
7475 beforeUnwrap: function( node ) {
7576 // FIXME: $( node ).data( 'display' ) doesn't exist any more
@@ -130,7 +131,7 @@
131132 }
132133
133134 var $template = $( this )
134 - .wrap( '<div class="wikiEditor-template"></div>' )
 135+ .wrap( '<span class="wikiEditor-template"></span>' )
135136 .addClass( 'wikiEditor-template-text wikiEditor-nodisplay' )
136137 .parent()
137138 .addClass( 'wikiEditor-template-collapsed' )
@@ -139,10 +140,11 @@
140141 $( '<span />' )
141142 .addClass( 'wikiEditor-template-name wikiEditor-noinclude' )
142143 .text( model.getName() )
143 - .mousedown( function(){createDialog( $template );} ) //have to pass template so model stays in sync
 144+ .mousedown(toggleWikiTextEditor)
 145+ //.mousedown( function(){createDialog( $template );} ) //have to pass template so model stays in sync
144146 .prependTo( $template );
145147
146 -
 148+ /*
147149 var $options = $( '<ul />' )
148150 .addClass( 'wikiEditor-template-modes wikiEditor-noinclude' )
149151 .append( $( '<li />' )
@@ -151,7 +153,7 @@
152154 $.wikiEditor.imgPath + 'templateEditor/' + 'wiki-text.png' ) )
153155 .mousedown( toggleWikiTextEditor ) )
154156 .insertAfter( $template.find( '.wikiEditor-template-name' ) );
155 -
 157+ */
156158 $(this).data( 'setupDone', true );
157159
158160 function toggleWikiTextEditor(){
@@ -670,7 +672,6 @@
671673 this.params = params;
672674 this.paramsByName = paramsByName;
673675 this.templateNameIndex = templateNameIndex;
674 - } // model
675 -}
676 -
 676+ } //model
 677+}
677678 }; } )( jQuery );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.html
@@ -98,6 +98,7 @@
9999 margin-top: -3px;
100100 border: solid 1px #d9d9d9;
101101 padding-left: 4px;
 102+ display: block;
102103 }
103104 .wikiEditor-template-end, .wikiEditor-template-start{
104105 color: blue;

Follow-up revisions

RevisionCommit summaryAuthorDate
r62832UsabilityInitiative: Recombine, bump style versions for r62724catrope19:15, 22 February 2010

Status & tagging log