r62704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r62703‎ | r62704 | r62705 >
Date:14:47, 19 February 2010
Author:ialex
Status:deferred
Tags:
Comment:
* Added $wgFixArabicUnicode, $wgFixMalayalamUnicode, $wgDebugPrintHttpHeaders, $wgDebugTimestamps, $wgMemCachedTimeout, $wgBlockDisablesLogin, $wgAsyncHTTPTimeout and $wgSearchSuggestCacheExpiry
* Removed $wgFixArchaicUnicode, $wgDebugSquid and $wgSquidResponseLimit
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)
  • /trunk/extensions/Configure/scripts/findSettings.php (modified) (history)
  • /trunk/extensions/Configure/settings/Settings-core.php (modified) (history)
  • /trunk/extensions/Configure/settings/Settings.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
——@@ -1,6 +1,12 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.15.11 - 19 February 2010
 6+ * Added $wgFixArabicUnicode, $wgFixMalayalamUnicode, $wgDebugPrintHttpHeaders,
 7+ $wgDebugTimestamps, $wgMemCachedTimeout, $wgBlockDisablesLogin,
 8+ $wgAsyncHTTPTimeout and $wgSearchSuggestCacheExpiry
 9+ * Removed $wgFixArchaicUnicode, $wgDebugSquid and $wgSquidResponseLimit
 10+
511 0.15.10 - 18 February 2010
612 Added support for GroupsSidebar, QPoll, SendmailToWiki, TemplateInfo,
713 Validator and Wikilog extensions.
Index: trunk/extensions/Configure/scripts/findSettings.php
——@@ -138,13 +138,12 @@
139139 } else {
140140 $allSettings = array_keys( $coreSettings->getAllSettings() );
141141 $ignoreList = array(
142 - 'wgAuth', 'wgCommandLineMode', 'wgCheckSerialized', 'wgConf','wgDBconnection',
143 - 'wgEnableNewpagesUserFilter', 'wgEnableSerializedMessages', 'wgEnableSorbs',
144 - 'wgEnforceHtmlIds', 'wgLegacySchemaConversion', 'wgMaintenanceScripts',
145 - 'wgMemCachedDebug', 'wgOldChangeTagsIndex', 'wgProxyKey', 'wgSorbsUrl',
146 - 'wgValidSkinNames', 'wgVectorExtraStyles', 'wgVersion',
147 - // For now
148 - 'wgDummyLanguageCodes', 'wgAsyncHTTPTimeout',
 142+ 'wgAuth', 'wgCommandLineMode', 'wgCheckSerialized', 'wgConf',
 143+ 'wgDBconnection', 'wgDummyLanguageCodes', 'wgEnableNewpagesUserFilter',
 144+ 'wgEnableSerializedMessages', 'wgEnableSorbs', 'wgExperimentalHtmlIds',
 145+ 'wgLegacySchemaConversion', 'wgMaintenanceScripts', 'wgMemCachedDebug',
 146+ 'wgOldChangeTagsIndex', 'wgProxyKey', 'wgSorbsUrl', 'wgValidSkinNames',
 147+ 'wgVectorExtraStyles', 'wgVersion',
149148 );
150149 }
151150
Index: trunk/extensions/Configure/settings/Settings.i18n.php
——@@ -144,6 +144,7 @@
145145 'configure-setting-wgMaxUploadSize' => 'Maximum allowed upload size',
146146 'configure-setting-wgHTTPTimeout' => 'Timeout for HTTP requests',
147147 'configure-setting-wgHTTPProxy' => 'HTTP Proxy to use',
 148+ 'configure-setting-wgAsyncHTTPTimeout' => 'Timeout for asynchronous HTTP requests',
148149 'configure-setting-wgVersion' => 'MediaWiki version',
149150 'configure-setting-wgAllowSpecialInclusion' => 'Allow inclusion of special pages',
150151 'configure-setting-wgExportAllowHistory' => 'Allow exports to include full history',
——@@ -210,6 +211,8 @@
211212 'configure-setting-wgDebugRawPage' => 'Leave requests for CSS/JS pages out of debug log',
212213 'configure-setting-wgDebugLogPrefix' => 'Prefix for debug log lines',
213214 'configure-setting-wgDebugRedirects' => 'Displays redirect location instead of actually redirecting to the target URL',
 215+ 'configure-setting-wgDebugPrintHttpHeaders' => 'Print HTTP headers for every request in the debug information',
 216+ 'configure-setting-wgDebugTimestamps' => 'Prefix debug messages with relative timestamp',
214217 'configure-setting-wgDevelopmentWarnings' => 'Throw PHP notices for some possible error conditions and for deprecated functions',
215218 'configure-setting-wgShowExceptionDetails' => 'Print a complete stack trace for exceptions',
216219 'configure-setting-wgShowDBErrorBacktrace' => 'Print a complete stack trace for database errors',
——@@ -231,7 +234,8 @@
232235 'configure-setting-wgDisableSearchUpdate' => 'Disable updates to search',
233236 'configure-setting-wgDisableTextSearch' => 'Disable full-text search',
234237 'configure-setting-wgEdititis' => 'Display user edit counts in various prominent places',
235 - 'configure-setting-wgFixArchaicUnicode' => 'Clean up archaic Unicode sequences in Arabic and Malayalam text',
 238+ 'configure-setting-wgFixArabicUnicode' => 'Clean up archaic Unicode sequences in Arabic text',
 239+ 'configure-setting-wgFixMalayalamUnicode' => 'Clean up archaic Unicode sequences in Malayalam text',
236240 'configure-setting-wgFixDoubleRedirects' => 'Fix double redirects after a page move',
237241 'configure-setting-wgInvalidRedirectTargets' => 'Array of invalid page redirect targets',
238242 'configure-setting-wgMaximumMovedPages' => 'Maximum number of pages to move at once when moving subpages with a page',
——@@ -253,7 +257,6 @@
254258 'configure-setting-wgInternalServer' => 'Internal server name as known to Squid, if different',
255259 'configure-setting-wgMaxSquidPurgeTitles' => 'Maximum number of page titles to purge in any one client operation',
256260 'configure-setting-wgSquidMaxage' => 'Cache timeout for the Squid',
257 - 'configure-setting-wgSquidResponseLimit' => 'Character limit for Squid purge responses',
258261 'configure-setting-wgSquidServers' => 'A list of proxy servers (IP-addresses if possible) to purge on changes',
259262 'configure-setting-wgSquidServersNoPurge' => 'A list of proxy servers (IP-addresses if possible) to not purge on changes',
260263 'configure-setting-wgUseESI' => 'Required setting when using Squid3 with ESI support',
——@@ -311,6 +314,7 @@
312315 'configure-setting-wgSearchForwardUrl' => 'Forward search requests',
313316 'configure-setting-wgSearchEverythingOnlyLoggedIn' => 'Make the "searcheverything" preference effective only for logged-in users',
314317 'configure-setting-wgSearchHighlightBoundaries' => 'Regexp to match word boundaries',
 318+ 'configure-setting-wgSearchSuggestCacheExpiry' => 'Expiry time for search suggestion responses',
315319 'configure-setting-wgCountTotalSearchHits' => 'Let the search engine count total search matches to present in Special:Search',
316320 'configure-setting-wgUseTwoButtonsSearchForm' => "Sidebar's search form behavior",
317321 'configure-setting-wgCountCategorizedImagesAsUsed' => 'On [[Special:UnusedImages]], consider files used if they are put into a category',
——@@ -456,6 +460,7 @@
457461 'configure-setting-wgDjvuTxt' => 'Path of the djvutxt DjVu text extraction utility',
458462 'configure-setting-wgMemCachedPersistent' => 'Use persistent memcached connections',
459463 'configure-setting-wgMemCachedServers' => 'Memcached Servers',
 464+ 'configure-setting-wgMemCachedTimeout' => 'Memcached server connection timeout in microseconds',
460465 'configure-setting-wgSessionsInMemcached' => 'Store sessions in memcached',
461466 'configure-setting-wgUseMemCached' => 'Use memcached',
462467 'configure-setting-wgCacheDirectory' => 'Directory for caching data in the local filesystem',
——@@ -582,6 +587,7 @@
583588 'configure-setting-wgRC2UDPPort' => 'Port for recent changes UDP notifications',
584589 'configure-setting-wgRC2UDPPrefix' => 'Prefix for lines sent to UDP for recent changes',
585590 'configure-setting-wgBlockAllowsUTEdit' => 'Allow a blocked user to edit his own talk page',
 591+ 'configure-setting-wgBlockDisablesLogin' => 'Disallow blocked users to login',
586592 'configure-setting-wgSysopEmailBans' => 'Allow administrators to ban users from accessing [[Special:EmailUser]]',
587593 'configure-setting-wgSysopRangeBans' => 'Allow administrators to ban IP ranges',
588594 'configure-setting-wgSysopUserBans' => 'Allow administrators to ban logged-in users',
——@@ -597,7 +603,6 @@
598604 'configure-setting-wgUsersNotifiedOnAllChanges' => 'Usernames who will be sent a notification e-mail for every change which occurs on a wiki',
599605 'configure-setting-wgDebugFunctionEntry' => 'Output debug message on every wfProfileIn/wfProfileOut',
600606 'configure-setting-wgDebugProfiling' => 'Detects non-matching wfProfileIn/wfProfileOut calls',
601 - 'configure-setting-wgDebugSquid' => 'Lots of debugging output from SquidUpdate.php',
602607 'configure-setting-wgProfileCallTree' => 'Print a raw call tree instead of per-function report',
603608 'configure-setting-wgProfileLimit' => 'Only record profiling information for pages that took longer than this',
604609 'configure-setting-wgProfileOnly' => 'Do not put non-profiling information into log file',
Index: trunk/extensions/Configure/settings/Settings-core.php
——@@ -30,7 +30,8 @@
3131 'wgPageShowWatchingUsers' => 'bool',
3232 'wgEdititis' => 'bool',
3333 'wgShowHostnames' => 'bool',
34 - 'wgFixArchaicUnicode' => 'bool',
 34+ 'wgFixArabicUnicode' => 'bool',
 35+ 'wgFixMalayalamUnicode' => 'bool',
3536 'wgFixDoubleRedirects' => 'bool',
3637 'wgEnableAPI' => 'bool',
3738 'wgEnableWriteAPI' => 'bool',
——@@ -294,6 +295,8 @@
295296 'wgDebugRawPage' => 'bool',
296297 'wgDebugLogPrefix' => 'text',
297298 'wgDebugRedirects' => 'bool',
 299+ 'wgDebugPrintHttpHeaders' => 'bool',
 300+ 'wgDebugTimestamps' => 'bool',
298301 'wgDevelopmentWarnings' => 'bool',
299302 'wgShowDebug' => 'bool',
300303 'wgShowExceptionDetails' => 'bool',
——@@ -304,7 +307,6 @@
305308 'profiling' => array(
306309 'wgDebugFunctionEntry' => 'bool',
307310 'wgDebugProfiling' => 'bool',
308 - 'wgDebugSquid' => 'bool',
309311 'wgProfileCallTree' => 'bool',
310312 'wgProfileLimit' => 'int',
311313 'wgProfileOnly' => 'bool',
——@@ -384,6 +386,7 @@
385387 # 'wgMemCachedDebug' => 'bool', # Does not appear to be a setting, just a global
386388 'wgMemCachedPersistent' => 'bool',
387389 'wgMemCachedServers' => 'array',
 390+ 'wgMemCachedTimeout' => 'int',
388391 'wgSessionsInMemcached' => 'bool',
389392 'wgUseMemCached' => 'bool',
390393 ),
——@@ -407,7 +410,6 @@
408411 'access' => array(
409412 'wgAccountCreationThrottle' => 'int',
410413 'wgAllowPageInfo' => 'bool',
411 - 'wgBlockCIDRLimit' => 'int',
412414 'wgDisabledActions' => 'array',
413415 'wgNewPasswordExpiry' => 'int',
414416 'wgEmailConfirmToEdit' => 'bool',
——@@ -420,6 +422,8 @@
421423 ),
422424 'block' => array(
423425 'wgBlockAllowsUTEdit' => 'bool',
 426+ 'wgBlockDisablesLogin' => 'bool',
 427+ 'wgBlockCIDRLimit' => 'int',
424428 'wgSysopEmailBans' => 'bool',
425429 'wgSysopRangeBans' => 'bool',
426430 'wgSysopUserBans' => 'bool',
——@@ -457,6 +461,7 @@
458462 'wgMaxUploadSize' => 'int',
459463 'wgHTTPTimeout' => 'int',
460464 'wgHTTPProxy' => 'text',
 465+ 'wgAsyncHTTPTimeout' => 'int',
461466 ),
462467 'sharedupload' => array(
463468 'wgForeignFileRepos' => 'array',
——@@ -706,6 +711,7 @@
707712 'wgSearchForwardUrl' => 'text',
708713 'wgSearchEverythingOnlyLoggedIn' => 'bool',
709714 'wgSearchHighlightBoundaries' => 'text',
 715+ 'wgSearchSuggestCacheExpiry' => 'int',
710716 'wgCountTotalSearchHits' => 'bool',
711717 'wgUseTwoButtonsSearchForm' => 'bool',
712718 ),
——@@ -732,7 +738,6 @@
733739 'wgInternalServer' => 'text',
734740 'wgMaxSquidPurgeTitles' => 'int',
735741 'wgSquidMaxage' => 'int',
736 - 'wgSquidResponseLimit' => 'int',
737742 'wgUseESI' => 'bool',
738743 'wgUsePrivateIPs' => 'bool',
739744 'wgUseXVO' => 'bool',
Index: trunk/extensions/Configure/Configure.php
——@@ -18,7 +18,7 @@
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
2020 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2121 'descriptionmsg' => 'configure-desc',
22 - 'version' => '0.15.10',
 22+ 'version' => '0.15.11',
2323 );
2424
2525 # Configuration part

Status & tagging log