r62539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62538‎ | r62539 | r62540 >
Date:20:18, 15 February 2010
Author:mah
Status:ok
Tags:
Comment:
fixes #22501 follow up r61101 remove superfluous, buggy code that was over-rideing displaytitle
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -556,6 +556,8 @@
557557 'wgHtml5' => true,
558558 'wgWellFormedXml' => true,
559559 'wgAllowMicrodataAttributes' => true,
 560+ 'wgAllowDisplayTitle' => true,
 561+ 'wgRestrictDisplayTitle' => false,
560562 );
561563
562564 if ($config) {
Index: trunk/phase3/maintenance/parserTests.txt
@@ -7781,8 +7781,31 @@
77827782 </p>
77837783 !! end
77847784
 7785+!! test
 7786+Verify that displaytitle works (bug #22501) no displaytitle
 7787+!! options
 7788+showtitle
 7789+!! input
 7790+this is not the the title
 7791+!! result
77857792
 7793+<p>this is not the the title
 7794+</p>
 7795+!! end
77867796
 7797+!! test
 7798+Verify that displaytitle works (bug #22501)
 7799+!! options
 7800+showtitle
 7801+!! input
 7802+this is not the the title
 7803+{{DISPLAYTITLE:screen}}
 7804+!! result
 7805+screen
 7806+<p>this is not the the title
 7807+</p>
 7808+!! end
 7809+
77877810 TODO:
77887811 more images
77897812 more tables
Index: trunk/phase3/includes/parser/Parser.php
@@ -365,13 +365,6 @@
366366 // won't pick it up. This is probably expected behavior.
367367 if ( $wgContLang->getConvRuleTitle() ) {
368368 $this->mOutput->setTitleText( $wgContLang->getConvRuleTitle() );
369 - } elseif ( !( $wgDisableLangConversion
370 - || isset( $this->mDoubleUnderscores['notitleconvert'] ) ) ) {
371 - if ( $title->getNamespace() == NS_SPECIAL ) {
372 - $this->setTitle( $wgContLang->convert( $title ) );
373 - } else {
374 - $this->mOutput->setTitleText( $wgContLang->convert( $title->getPrefixedText() ) );
375 - }
376369 }
377370
378371 $text = $this->mStripState->unstripNoWiki( $text );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61101follow up r60832 and follow up r60763...mah19:14, 15 January 2010

Status & tagging log