r62461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r62460‎ | r62461 | r62462 >
Date:14:29, 14 February 2010
Author:reedy
Status:ok
Tags:
Comment:
Fixup spaces to tabs from r62404
Modified paths:
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiImport.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)
  • /trunk/phase3/includes/api/ApiProtect.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiRollback.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMove.php
——@@ -210,7 +210,7 @@
211211 );
212212 }
213213
214 - public function getPossibleErrors() {
 214+ public function getPossibleErrors() {
215215 return array_merge( parent::getPossibleErrors(), array(
216216 array( 'missingparam', 'to' ),
217217 array( 'missingparam', 'token' ),
——@@ -220,7 +220,7 @@
221221 array( 'notanarticle' ),
222222 array( 'invalidtitle', 'to' ),
223223 array( 'sharedfile-exists' ),
224 - ) );
 224+ ) );
225225 }
226226
227227 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiProtect.php
——@@ -172,7 +172,7 @@
173173 );
174174 }
175175
176 - public function getPossibleErrors() {
 176+ public function getPossibleErrors() {
177177 return array_merge( parent::getPossibleErrors(), array(
178178 array( 'missingparam', 'title' ),
179179 array( 'missingparam', 'token' ),
——@@ -186,7 +186,7 @@
187187 array( 'protect-invalidlevel', 'level' ),
188188 array( 'invalidexpiry', 'expiry' ),
189189 array( 'pastexpiry', 'expiry' ),
190 - ) );
 190+ ) );
191191 }
192192
193193 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
——@@ -454,13 +454,13 @@
455455 }
456456 }
457457
458 - public function getPossibleErrors() {
 458+ public function getPossibleErrors() {
459459 return array_merge( parent::getPossibleErrors(), array(
460460 array( 'invalidtitle', 'title' ),
461461 array( 'missingparam', 'title' ),
462462 array( 'code' => 'bad_image_title', 'info' => "The title for {$this->getModuleName()} query must be an image" ),
463463 array( 'code' => '_badcontinue', 'info' => 'Invalid continue param. You should pass the original value returned by the previous query' ),
464 - ) );
 464+ ) );
465465 }
466466
467467 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiRollback.php
——@@ -114,7 +114,7 @@
115115 );
116116 }
117117
118 - public function getPossibleErrors() {
 118+ public function getPossibleErrors() {
119119 return array_merge( parent::getPossibleErrors(), array(
120120 array( 'missingparam', 'title' ),
121121 array( 'missingparam', 'user' ),
——@@ -122,7 +122,7 @@
123123 array( 'invalidtitle', 'title' ),
124124 array( 'notanarticle' ),
125125 array( 'invaliduser', 'user' ),
126 - ) );
 126+ ) );
127127 }
128128
129129 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiQueryBase.php
——@@ -408,11 +408,11 @@
409409 return substr( $this->keyToTitle( $keyPart . 'x' ), 0, - 1 );
410410 }
411411
412 - public function getPossibleErrors() {
 412+ public function getPossibleErrors() {
413413 return array_merge( parent::getPossibleErrors(), array(
414414 array( 'invalidtitle', 'title' ),
415415 array( 'invalidtitle', 'key' ),
416 - ) );
 416+ ) );
417417 }
418418
419419 /**
Index: trunk/phase3/includes/api/ApiDelete.php
——@@ -210,14 +210,14 @@
211211 );
212212 }
213213
214 - public function getPossibleErrors() {
 214+ public function getPossibleErrors() {
215215 return array_merge( parent::getPossibleErrors(), array(
216216 array( 'missingparam', 'token' ),
217217 array( 'invalidtitle', 'title' ),
218218 array( 'nosuchpageid', 'pageid' ),
219219 array( 'notanarticle' ),
220220 array( 'hookaborted', 'error' ),
221 - ) );
 221+ ) );
222222 }
223223
224224 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiImport.php
——@@ -141,7 +141,7 @@
142142 );
143143 }
144144
145 - public function getPossibleErrors() {
 145+ public function getPossibleErrors() {
146146 return array_merge( parent::getPossibleErrors(), array(
147147 array( 'cantimport' ),
148148 array( 'missingparam', 'token' ),
——@@ -150,7 +150,7 @@
151151 array( 'cantimport-upload' ),
152152 array( 'import-unknownerror', 'source' ),
153153 array( 'import-unknownerror', 'result' ),
154 - ) );
 154+ ) );
155155 }
156156
157157 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -346,7 +346,7 @@
347347 return 'Create and edit pages.';
348348 }
349349
350 - public function getPossibleErrors() {
 350+ public function getPossibleErrors() {
351351 return array_merge( parent::getPossibleErrors(), array(
352352 array( 'missingparam', 'title' ),
353353 array( 'missingtext' ),
——@@ -380,7 +380,7 @@
381381 array( 'unknownerror', 'retval' ),
382382 array( 'code' => 'nosuchsection', 'info' => 'There is no section section.' ),
383383 array( 'code' => 'invalidsection', 'info' => 'The section parameter must be set to an integer or \'new\'' ),
384 - ) );
 384+ ) );
385385 }
386386
387387 private function getMaxArticleSize() {
Index: trunk/phase3/includes/api/ApiUndelete.php
——@@ -118,7 +118,7 @@
119119 );
120120 }
121121
122 - public function getPossibleErrors() {
 122+ public function getPossibleErrors() {
123123 return array_merge( parent::getPossibleErrors(), array(
124124 array( 'missingparam', 'title' ),
125125 array( 'missingparam', 'token' ),
——@@ -127,7 +127,7 @@
128128 array( 'sessionfailure' ),
129129 array( 'invalidtitle', 'title' ),
130130 array( 'cannotundelete' ),
131 - ) );
 131+ ) );
132132 }
133133
134134 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiQueryRevisions.php
——@@ -561,7 +561,7 @@
562562 );
563563 }
564564
565 - public function getPossibleErrors() {
 565+ public function getPossibleErrors() {
566566 return array_merge( parent::getPossibleErrors(), array(
567567 array( 'nosuchrevid', 'diffto' ),
568568 array( 'code' => 'revids', 'info' => 'The revids= parameter may not be used with the list options (limit, startid, endid, dirNewer, start, end).' ),
——@@ -571,7 +571,7 @@
572572 array( 'code' => 'badparams', 'info' => 'end and endid cannot be used together' ),
573573 array( 'code' => 'badparams', 'info' => 'user and excludeuser cannot be used together' ),
574574 array( 'code' => 'nosuchsection', 'info' => 'There is no section section in rID' ),
575 - ) );
 575+ ) );
576576 }
577577
578578 protected function getExamples() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62404Rest of dieUsageMsg in getPossibleErrorsreedy00:28, 13 February 2010

Status & tagging log