r62417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62416‎ | r62417 | r62418 >
Date:02:27, 13 February 2010
Author:demon
Status:ok
Tags:
Comment:
Drop call to no-op wfSeedRandom()
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)
  • /trunk/extensions/Patroller/Patroller.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Patroller/Patroller.class.php
@@ -41,7 +41,6 @@
4242 }
4343
4444 # Prune old assignments if needed
45 - wfSeedRandom();
4645 if( 0 == mt_rand( 0, 499 ) )
4746 $this->pruneAssignments();
4847
Index: trunk/extensions/CheckUser/CheckUser.php
@@ -130,7 +130,6 @@
131131 $dbw->insert( 'cu_changes', $rcRow, __METHOD__ );
132132
133133 # Every 100th edit, prune the checkuser changes table.
134 - wfSeedRandom();
135134 if( 0 == mt_rand( 0, 99 ) ) {
136135 # Periodically flush old entries from the recentchanges table.
137136 global $wgCUDMaxAge;
Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -818,7 +818,6 @@
819819 }
820820
821821 # Every 30th view, prune old deleted items
822 - wfSeedRandom();
823822 if( 0 == mt_rand( 0, 29 ) ) {
824823 $this->runAutoMaintenance();
825824 }

Status & tagging log