r62351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62350‎ | r62351 | r62352 >
Date:05:17, 12 February 2010
Author:tstarling
Status:ok
Tags:
Comment:
Don't format old_id ranges in scientific (%E) notation.
Modified paths:
  • /trunk/phase3/maintenance/storage/storageTypeStats.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/storage/storageTypeStats.php
@@ -13,7 +13,7 @@
1414 }
1515
1616 $rangeStart = 0;
17 - $binSize = pow( 10, floor( log10( $endId ) ) - 3 );
 17+ $binSize = intval( pow( 10, floor( log10( $endId ) ) - 3 ) );
1818 if ( $binSize < 100 ) {
1919 $binSize = 100;
2020 }
@@ -52,8 +52,8 @@
5353 'COUNT(*) as count',
5454 ),
5555 array(
56 - 'old_id >= ' . $dbr->addQuotes( $rangeStart ),
57 - 'old_id < ' . $dbr->addQuotes( $rangeStart + $binSize )
 56+ 'old_id >= ' . intval( $rangeStart ),
 57+ 'old_id < ' . intval( $rangeStart + $binSize )
5858 ),
5959 __METHOD__,
6060 array( 'GROUP BY' => 'old_flags, class' )

Status & tagging log