r62285 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62284‎ | r62285 | r62286 >
Date:02:08, 11 February 2010
Author:aaron
Status:ok
Tags:
Comment:
Removed unneeded vars
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -8,7 +8,6 @@
99 # Process cache variables
1010 protected $stableRev = null;
1111 protected $pageConfig = null;
12 - protected $flags = array();
1312
1413 /**
1514 * Get a FlaggedArticle for a given title
@@ -106,7 +105,6 @@
107106 $srev = FlaggedRevision::newFromStable( $this->getTitle(), $flags );
108107 if ( $srev ) {
109108 $this->stableRev = $srev;
110 - $this->flags[$srev->getRevId()] = $srev->getTags();
111109 return $srev;
112110 } else {
113111 $this->stableRev = false;
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -120,7 +120,7 @@
121121 * Output review notice
122122 */
123123 public function displayTag() {
124 - global $wgOut, $wgRequest;
 124+ global $wgOut;
125125 $this->load();
126126 // Sanity check that this is a reviewable page
127127 if ( $this->article->isReviewable() ) {
@@ -182,7 +182,7 @@
183183 * Adds a quick review form on the bottom if needed
184184 */
185185 public function setPageContent( &$outputDone, &$pcache ) {
186 - global $wgRequest, $wgOut, $wgUser, $wgLang, $wgContLang;
 186+ global $wgRequest, $wgOut, $wgLang, $wgContLang;
187187 $this->load();
188188 # Only trigger on article view for content pages, not for protect/delete/hist...
189189 $action = $wgRequest->getVal( 'action', 'view' );
@@ -596,7 +596,7 @@
597597 * @returns bool, diff added to output
598598 */
599599 protected function maybeShowTopDiff( $srev, $quality ) {
600 - global $wgUser, $wgOut, $wgMemc;
 600+ global $wgUser, $wgOut;
601601 $this->load();
602602 if ( !$wgUser->getBoolOption( 'flaggedrevsviewdiffs' ) )
603603 return false; // nothing to do here

Status & tagging log