r62219 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62218‎ | r62219 | r62220 >
Date:03:14, 10 February 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/Maps/OpenLayers/OpenLayerFunctions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/OpenLayers/OpenLayerFunctions.js
@@ -120,12 +120,12 @@
121121 if (markerData.title.length + markerData.label.length > 0 ) {
122122
123123 // This is the handler for the mousedown event on the marker, and displays the popup
124 - marker.events.register("mousedown", marker,
 124+ marker.events.register('mousedown', marker,
125125 function(evt) {
126126 var popup = new OpenLayers.Feature(markerLayer, markerData.lonlat).createPopup(true);
127127
128128 if (markerData.title.length > 0 && markerData.label.length > 0) { // Add the title and label to the popup text
129 - popup.setContentHTML("<b>" + markerData.title + "</b><hr />" + markerData.label);
 129+ popup.setContentHTML('<b>' + markerData.title + '</b><hr />' + markerData.label);
130130 }
131131 else {
132132 popup.setContentHTML(markerData.title + markerData.label);
@@ -154,7 +154,7 @@
155155
156156 function initOLSettings(minWidth, minHeight) {
157157 OpenLayers.IMAGE_RELOAD_ATTEMPTS = 3;
158 - OpenLayers.Util.onImageLoadErrorColor = "transparent";
159 - OpenLayers.Feature.prototype.popupClass = OpenLayers.Class(OpenLayers.Popup.FramedCloud, {"autoSize": true, "minSize": new OpenLayers.Size(minWidth, minHeight)});
 158+ OpenLayers.Util.onImageLoadErrorColor = 'transparent';
 159+ OpenLayers.Feature.prototype.popupClass = OpenLayers.Class(OpenLayers.Popup.FramedCloud, {'autoSize': true, 'minSize': new OpenLayers.Size(minWidth, minHeight)});
160160 }
161161

Status & tagging log